git binary patches: don't print the header for identical files

mercurial/patch.py

@@ -415,14 +415,15 b' def b85diff(fp, to, tn):'
     tohash = gitindex(to)
     tnhash = gitindex(tn)
     if tohash == tnhash:
-        return
+        return ""
+
     # TODO: deltas
-    fp.write('index %s..%s\nGIT binary patch\nliteral %s\n' %
-             (tohash, tnhash, len(tn)))
-
-    tn = ''.join([fmtline(l) for l in chunk(zlib.compress(tn))])
-    fp.write(tn)
-    fp.write('\n')
+    ret = ['index %s..%s\nGIT binary patch\nliteral %s\n' %
+           (tohash, tnhash, len(tn))]
+    for l in chunk(zlib.compress(tn)):
+        ret.append(fmtline(l))
+    ret.append('\n')
+    return ''.join(ret)
 
 def diff(repo, node1=None, node2=None, files=None, match=util.always,
          fp=None, changes=None, opts=None):
@@ -615,11 +616,11 b' def diff(repo, node1=None, node2=None, f'
                     dodiff = 'binary'
             r = None
             header.insert(0, 'diff --git a/%s b/%s\n' % (a, b))
-        if dodiff == 'binary':
-            fp.write(''.join(header))
-            b85diff(fp, to, tn)
-        elif dodiff:
-            text = mdiff.unidiff(to, date1, tn, date2(f), f, r, opts=opts)
+        if dodiff:
+            if dodiff == 'binary':
+                text = b85diff(fp, to, tn)
+            else:
+                text = mdiff.unidiff(to, date1, tn, date2(f), f, r, opts=opts)
             if text or len(header) > 1:
                 fp.write(''.join(header))
             fp.write(text)

tests/test-diff-binary-file.out

@@ -21,4 +21,3 b' zXmmQA+wDgE!qR9o8jr`%=ab_&uh(l?R=r;Tjiqo'
 gQItJW-{SoTm)8|5##k|m00000NkvXXu0mjf3JwksH2?qr
 
 % diff --git -r 0 -r 2
-diff --git a/binfile.bin b/binfile.bin