largefiles: refactor usercachepath - extract user cache path function

It is convenient to have the user cache location explicitly.

hgext/largefiles/lfutil.py

@@ -51,30 +51,38 b' def link(src, dest):'
         os.chmod(dest, os.stat(src).st_mode)
 
 def usercachepath(ui, hash):
+    '''Return the correct location in the "global" largefiles cache for a file
+    with the given hash.
+    This cache is used for sharing of largefiles across repositories - both
+    to preserve download bandwidth and storage space.'''
+    path = _usercachedir(ui)
+    if path:
+        return os.path.join(path, hash)
+    return None
+
+def _usercachedir(ui):
+    '''Return the location of the "global" largefiles cache.'''
     path = ui.configpath(longname, 'usercache', None)
     if path:
-        path = os.path.join(path, hash)
-    else:
+        return path
         if os.name == 'nt':
             appdata = os.getenv('LOCALAPPDATA', os.getenv('APPDATA'))
             if appdata:
-                path = os.path.join(appdata, longname, hash)
+            return os.path.join(appdata, longname)
         elif platform.system() == 'Darwin':
             home = os.getenv('HOME')
             if home:
-                path = os.path.join(home, 'Library', 'Caches',
-                                    longname, hash)
+            return os.path.join(home, 'Library', 'Caches', longname)
         elif os.name == 'posix':
             path = os.getenv('XDG_CACHE_HOME')
             if path:
-                path = os.path.join(path, longname, hash)
-            else:
+            return os.path.join(path, longname)
                 home = os.getenv('HOME')
                 if home:
-                    path = os.path.join(home, '.cache', longname, hash)
+            return os.path.join(home, '.cache', longname)
         else:
             raise error.Abort(_('unknown operating system: %s\n') % os.name)
-    return path
+    return None
 
 def inusercache(ui, hash):
     path = usercachepath(ui, hash)