merge with stable

mercurial/hook.py

@@ -142,9 +142,14 b' def hook(ui, repo, name, throw=False, **'
         return False
 
     r = False
+    oldstdout = -1
 
-    oldstdout = -1
-    if _redirect:
+    try:
+        for hname, cmd in _allhooks(ui):
+            if hname.split('.')[0] != name or not cmd:
+                continue
+
+            if oldstdout == -1 and _redirect:
         try:
             stdoutno = sys.__stdout__.fileno()
             stderrno = sys.__stderr__.fileno()
@@ -153,14 +158,10 b' def hook(ui, repo, name, throw=False, **'
                 sys.__stdout__.flush()
                 oldstdout = os.dup(stdoutno)
                 os.dup2(stderrno, stdoutno)
-        except AttributeError:
-            # __stdout__/__stderr__ doesn't have fileno(), it's not a real file
+                except (OSError, AttributeError):
+                    # files seem to be bogus, give up on redirecting (WSGI, etc)
             pass
 
-    try:
-        for hname, cmd in _allhooks(ui):
-            if hname.split('.')[0] != name or not cmd:
-                continue
             if util.safehasattr(cmd, '__call__'):
                 r = _pythonhook(ui, repo, name, hname, cmd, args, throw) or r
             elif cmd.startswith('python:'):

mercurial/phases.py

@@ -103,7 +103,7 b' Note: old client behave as a publishing '
 import errno
 from node import nullid, nullrev, bin, hex, short
 from i18n import _
-import util
+import util, error
 import obsolete
 
 allphases = public, draft, secret = range(3)

mercurial/revset.py

@@ -584,14 +584,6 b' def _descendants(repo, subset, x, follow'
     if not args:
         return []
     s = set(_revdescendants(repo, args, followfirst)) | set(args)
-
-    if len(subset) == len(repo):
-        # the passed in revisions may not exist, -1 for example
-        for arg in args:
-            if arg not in subset:
-                s.remove(arg)
-        return list(s)
-
     return [r for r in subset if r in s]
 
 def descendants(repo, subset, x):
@@ -1349,9 +1341,6 b' def roots(repo, subset, x):'
     Changesets in set with no parent changeset in set.
     """
     s = set(getset(repo, repo.changelog, x))
-    if len(subset) == len(repo):
-        subset = s
-    else:
         subset = [r for r in subset if r in s]
     cs = _children(repo, subset, s)
     return [r for r in subset if r not in cs]

mercurial/util.py

@@ -899,7 +899,7 b' class chunkbuffer(object):'
         """Read L bytes of data from the iterator of chunks of data.
         Returns less than L bytes if the iterator runs dry."""
         left = l
-        buf = ''
+        buf = []
         queue = self._queue
         while left > 0:
             # refill the queue
@@ -917,11 +917,11 b' class chunkbuffer(object):'
             left -= len(chunk)
             if left < 0:
                 queue.appendleft(chunk[left:])
-                buf += chunk[:left]
+                buf.append(chunk[:left])
             else:
-                buf += chunk
+                buf.append(chunk)
 
-        return buf
+        return ''.join(buf)
 
 def filechunkiter(f, size=65536, limit=None):
     """Create a generator that produces the data in the file size

tests/test-phases.t

@@ -339,6 +339,15 b' test that phase are displayed in log at '
   
   
 
+(Issue3707)
+test invalid phase name
+
+  $ mkcommit I --config phases.new-commit='babar'
+  transaction abort!
+  rollback completed
+  abort: phases.new-commit: not a valid phase name ('babar')
+  [255]
+  
 Test phase command
 ===================