issue 1144: prevent traceback on verify of bundles

mercurial/verify.py

@@ -1,235 +1,238 b''
 # verify.py - repository integrity checking for Mercurial
 #
 # Copyright 2006, 2007 Matt Mackall <[e-mail]>
 #
 # This software may be used and distributed according to the terms
 # of the GNU General Public License, incorporated herein by reference.
 
 from node import nullid, short
 from i18n import _
 import revlog, util
 
 def verify(repo):
     lock = repo.lock()
     try:
         return _verify(repo)
     finally:
         del lock
 
 def _verify(repo):
     mflinkrevs = {}
     filelinkrevs = {}
     filenodes = {}
     revisions = 0
     badrevs = {}
     errors = [0]
     warnings = [0]
     ui = repo.ui
     cl = repo.changelog
     mf = repo.manifest
 
+    if not repo.cancopy():
+        raise util.Abort(_("cannot verify bundle or remote repos"))
+
     def err(linkrev, msg, filename=None):
         if linkrev != None:
             badrevs[linkrev] = True
         else:
             linkrev = '?'
         msg = "%s: %s" % (linkrev, msg)
         if filename:
             msg = "%s@%s" % (filename, msg)
         ui.warn(" " + msg + "\n")
         errors[0] += 1
 
     def exc(linkrev, msg, inst, filename=None):
         if isinstance(inst, KeyboardInterrupt):
             ui.warn(_("interrupted"))
             raise
         err(linkrev, "%s: %s" % (msg, inst), filename)
 
     def warn(msg):
         ui.warn(msg + "\n")
         warnings[0] += 1
 
     def checklog(obj, name):
         if not len(obj) and (havecl or havemf):
             err(0, _("empty or missing %s") % name)
             return
 
         d = obj.checksize()
         if d[0]:
             err(None, _("data length off by %d bytes") % d[0], name)
         if d[1]:
             err(None, _("index contains %d extra bytes") % d[1], name)
 
         if obj.version != revlog.REVLOGV0:
             if not revlogv1:
                 warn(_("warning: `%s' uses revlog format 1") % name)
         elif revlogv1:
             warn(_("warning: `%s' uses revlog format 0") % name)
 
     def checkentry(obj, i, node, seen, linkrevs, f):
         lr = obj.linkrev(node)
         if lr < 0 or (havecl and lr not in linkrevs):
             t = "unexpected"
             if lr < 0 or lr >= len(cl):
                 t = "nonexistent"
             err(None, _("rev %d point to %s changeset %d") % (i, t, lr), f)
             if linkrevs:
                 warn(_(" (expected %s)") % " ".join(map(str,linkrevs)))
             lr = None # can't be trusted
 
         try:
             p1, p2 = obj.parents(node)
             if p1 not in seen and p1 != nullid:
                 err(lr, _("unknown parent 1 %s of %s") %
                     (short(p1), short(n)), f)
             if p2 not in seen and p2 != nullid:
                 err(lr, _("unknown parent 2 %s of %s") %
                     (short(p2), short(p1)), f)
         except Exception, inst:
             exc(lr, _("checking parents of %s") % short(node), inst, f)
 
         if node in seen:
             err(lr, _("duplicate revision %d (%d)") % (i, seen[n]), f)
         seen[n] = i
         return lr
 
     revlogv1 = cl.version != revlog.REVLOGV0
     if ui.verbose or not revlogv1:
         ui.status(_("repository uses revlog format %d\n") %
                        (revlogv1 and 1 or 0))
 
     havecl = len(cl) > 0
     havemf = len(mf) > 0
 
     ui.status(_("checking changesets\n"))
     seen = {}
     checklog(cl, "changelog")
     for i in repo:
         n = cl.node(i)
         checkentry(cl, i, n, seen, [i], "changelog")
 
         try:
             changes = cl.read(n)
             mflinkrevs.setdefault(changes[0], []).append(i)
             for f in changes[3]:
                 filelinkrevs.setdefault(f, []).append(i)
         except Exception, inst:
             exc(i, _("unpacking changeset %s") % short(n), inst)
 
     ui.status(_("checking manifests\n"))
     seen = {}
     checklog(mf, "manifest")
     for i in mf:
         n = mf.node(i)
         lr = checkentry(mf, i, n, seen, mflinkrevs.get(n, []), "manifest")
         if n in mflinkrevs:
             del mflinkrevs[n]
 
         try:
             for f, fn in mf.readdelta(n).iteritems():
                 if not f:
                     err(lr, _("file without name in manifest"))
                 elif f != "/dev/null":
                     fns = filenodes.setdefault(f, {})
                     if fn not in fns:
                         fns[fn] = n
         except Exception, inst:
             exc(lr, _("reading manifest delta %s") % short(n), inst)
 
     ui.status(_("crosschecking files in changesets and manifests\n"))
 
     if havemf:
         for c, m in util.sort([(c, m) for m in mflinkrevs for c in mflinkrevs[m]]):
             err(c, _("changeset refers to unknown manifest %s") % short(m))
         del mflinkrevs
 
         for f in util.sort(filelinkrevs):
             if f not in filenodes:
                 lr = filelinkrevs[f][0]
                 err(lr, _("in changeset but not in manifest"), f)
 
     if havecl:
         for f in util.sort(filenodes):
             if f not in filelinkrevs:
                 try:
                     lr = min([repo.file(f).linkrev(n) for n in filenodes[f]])
                 except:
                     lr = None
                 err(lr, _("in manifest but not in changeset"), f)
 
     ui.status(_("checking files\n"))
 
     storefiles = {}
     for f, f2, size in repo.store.datafiles():
         if not f:
             err(None, _("cannot decode filename '%s'") % f2)
         elif size > 0:
             storefiles[f] = True
 
     files = util.sort(util.unique(filenodes.keys() + filelinkrevs.keys()))
     for f in files:
         fl = repo.file(f)
 
         for ff in fl.files():
             try:
                 del storefiles[ff]
             except KeyError:
                 err(0, _("missing revlog!"), ff)
 
         checklog(fl, f)
         seen = {}
         for i in fl:
             revisions += 1
             n = fl.node(i)
             lr = checkentry(fl, i, n, seen, filelinkrevs.get(f, []), f)
             if f in filenodes:
                 if havemf and n not in filenodes[f]:
                     err(lr, _("%s not in manifests") % (short(n)), f)
                 else:
                     del filenodes[f][n]
 
             # verify contents
             try:
                 t = fl.read(n)
                 rp = fl.renamed(n)
                 if len(t) != fl.size(i):
                     if not fl._readmeta(n): # ancient copy?
                         err(lr, _("unpacked size is %s, %s expected") %
                             (len(t), fl.size(i)), f)
             except Exception, inst:
                 exc(lr, _("unpacking %s") % short(n), inst, f)
 
             # check renames
             try:
                 if rp:
                     fl2 = repo.file(rp[0])
                     if not len(fl2):
                         err(lr, _("empty or missing copy source revlog %s:%s")
                             % (rp[0], short(rp[1])), f)
                     elif rp[1] == nullid:
                         warn(_("warning: %s@%s: copy source revision is nullid %s:%s")
                             % (f, lr, rp[0], short(rp[1])))
                     else:
                         rev = fl2.rev(rp[1])
             except Exception, inst:
                 exc(lr, _("checking rename of %s") % short(n), inst, f)
 
         # cross-check
         if f in filenodes:
             fns = [(mf.linkrev(l), n) for n,l in filenodes[f].items()]
             for lr, node in util.sort(fns):
                 err(lr, _("%s in manifests not found") % short(node), f)
 
     for f in storefiles:
         warn(_("warning: orphan revlog '%s'") % f)
 
     ui.status(_("%d files, %d changesets, %d total revisions\n") %
                    (len(files), len(cl), revisions))
     if warnings[0]:
         ui.warn(_("%d warnings encountered!\n") % warnings[0])
     if errors[0]:
         ui.warn(_("%d integrity errors encountered!\n") % errors[0])
         if badrevs:
             ui.warn(_("(first damaged changeset appears to be %d)\n")
                     % min(badrevs))
         return 1

tests/test-bundle

@@ -1,131 +1,142 b''
 #!/bin/sh
 
 cp "$TESTDIR"/printenv.py .
 
 echo "====== Setting up test"
 hg init test
 cd test
 echo 0 > afile
 hg add afile
 hg commit -m "0.0" -d "1000000 0"
 echo 1 >> afile
 hg commit -m "0.1" -d "1000000 0"
 echo 2 >> afile
 hg commit -m "0.2" -d "1000000 0"
 echo 3 >> afile
 hg commit -m "0.3" -d "1000000 0"
 hg update -C 0
 echo 1 >> afile
 hg commit -m "1.1" -d "1000000 0"
 echo 2 >> afile
 hg commit -m "1.2" -d "1000000 0"
 echo "a line" > fred
 echo 3 >> afile
 hg add fred
 hg commit -m "1.3" -d "1000000 0"
 hg mv afile adifferentfile
 hg commit -m "1.3m" -d "1000000 0"
 hg update -C 3
 hg mv afile anotherfile
 hg commit -m "0.3m" -d "1000000 0"
 hg verify
 cd ..
 hg init empty
 
 echo "====== Bundle --all"
 hg -R test bundle --all all.hg
 echo "====== Bundle test to full.hg"
 hg -R test bundle full.hg empty
 echo "====== Unbundle full.hg in test"
 hg -R test unbundle full.hg
 echo "====== Verify empty"
 hg -R empty heads
 hg -R empty verify
 
 echo "====== Pull full.hg into test (using --cwd)"
 hg --cwd test pull ../full.hg
 echo "====== Pull full.hg into empty (using --cwd)"
 hg --cwd empty pull ../full.hg
 echo "====== Rollback empty"
 hg -R empty rollback
 echo "====== Pull full.hg into empty again (using --cwd)"
 hg --cwd empty pull ../full.hg
 
 echo "====== Pull full.hg into test (using -R)"
 hg -R test pull full.hg
 echo "====== Pull full.hg into empty (using -R)"
 hg -R empty pull full.hg
 echo "====== Rollback empty"
 hg -R empty rollback
 echo "====== Pull full.hg into empty again (using -R)"
 hg -R empty pull full.hg
 
 echo "====== Log -R full.hg in fresh empty"
 rm -r empty
 hg init empty
 cd empty
 hg -R bundle://../full.hg log
 
 echo "====== Pull ../full.hg into empty (with hook)"
 echo '[hooks]' >> .hg/hgrc
 echo 'changegroup = python ../printenv.py changegroup' >> .hg/hgrc
 #doesn't work (yet ?)
 #hg -R bundle://../full.hg verify
 hg pull bundle://../full.hg
 echo "====== Rollback empty"
 hg rollback
 cd ..
 echo "====== Log -R bundle:empty+full.hg"
 hg -R bundle:empty+full.hg log --template="{rev} "
 echo ""
 echo "====== Pull full.hg into empty again (using -R; with hook)"
 hg -R empty pull full.hg
 
 echo "====== Create partial clones"
 rm -r empty
 hg init empty
 hg clone -r 3 test partial
 hg clone partial partial2
 cd partial
 echo "====== Log -R full.hg in partial"
 hg -R bundle://../full.hg log
 echo "====== Incoming full.hg in partial"
 hg incoming bundle://../full.hg
 echo "====== Outgoing -R full.hg vs partial2 in partial"
 hg -R bundle://../full.hg outgoing ../partial2
 echo "====== Outgoing -R does-not-exist.hg vs partial2 in partial"
 hg -R bundle://../does-not-exist.hg outgoing ../partial2
 cd ..
 
 echo "====== Direct clone from bundle (all-history)"
 hg clone full.hg full-clone
 hg -R full-clone heads
 rm -r full-clone
 
 # test for http://www.selenic.com/mercurial/bts/issue216
 echo "====== Unbundle incremental bundles into fresh empty in one go"
 rm -r empty
 hg init empty
 hg -R test bundle --base null -r 0 ../0.hg
 hg -R test bundle --base 0    -r 1 ../1.hg
 hg -R empty unbundle -u ../0.hg ../1.hg
 
 # test for 540d1059c802
 echo "====== test for 540d1059c802"
 hg init orig
 cd orig
 echo foo > foo
 hg add foo
 hg ci -m 'add foo' -d '0 0'
 
 hg clone . ../copy
 hg tag -d '0 0' foo
 
 cd ../copy
 echo >> foo
 hg ci -m 'change foo' -d '0 0'
 hg bundle ../bundle.hg ../orig
 
 cd ../orig
 hg incoming ../bundle.hg
 cd ..
+
+# test for http://www.selenic.com/mercurial/bts/issue1144
+echo "===== test that verify bundle does not traceback"
+# partial history bundle, fails w/ unkown parent
+hg -R bundle.hg verify
+# full history bundle, refuses to verify non-local repo
+hg -R all.hg verify
+# but, regular verify must continue to work
+hg -R orig verify
+
+

tests/test-bundle.out

@@ -1,311 +1,319 b''
 ====== Setting up test
 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 created new head
 1 files updated, 0 files merged, 2 files removed, 0 files unresolved
 checking changesets
 checking manifests
 crosschecking files in changesets and manifests
 checking files
 4 files, 9 changesets, 7 total revisions
 ====== Bundle --all
 9 changesets found
 ====== Bundle test to full.hg
 searching for changes
 9 changesets found
 ====== Unbundle full.hg in test
 adding changesets
 adding manifests
 adding file changes
 added 0 changesets with 0 changes to 4 files
 (run 'hg update' to get a working copy)
 ====== Verify empty
 changeset:   -1:000000000000
 tag:         tip
 user:        
 date:        Thu Jan 01 00:00:00 1970 +0000
 
 checking changesets
 checking manifests
 crosschecking files in changesets and manifests
 checking files
 0 files, 0 changesets, 0 total revisions
 ====== Pull full.hg into test (using --cwd)
 pulling from ../full.hg
 searching for changes
 no changes found
 ====== Pull full.hg into empty (using --cwd)
 pulling from ../full.hg
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 9 changesets with 7 changes to 4 files (+1 heads)
 (run 'hg heads' to see heads, 'hg merge' to merge)
 ====== Rollback empty
 rolling back last transaction
 ====== Pull full.hg into empty again (using --cwd)
 pulling from ../full.hg
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 9 changesets with 7 changes to 4 files (+1 heads)
 (run 'hg heads' to see heads, 'hg merge' to merge)
 ====== Pull full.hg into test (using -R)
 pulling from full.hg
 searching for changes
 no changes found
 ====== Pull full.hg into empty (using -R)
 pulling from full.hg
 searching for changes
 no changes found
 ====== Rollback empty
 rolling back last transaction
 ====== Pull full.hg into empty again (using -R)
 pulling from full.hg
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 9 changesets with 7 changes to 4 files (+1 heads)
 (run 'hg heads' to see heads, 'hg merge' to merge)
 ====== Log -R full.hg in fresh empty
 changeset:   8:836ac62537ab
 tag:         tip
 parent:      3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3m
 
 changeset:   7:80fe151401c2
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3m
 
 changeset:   6:1e3f6b843bd6
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3
 
 changeset:   5:024e4e7df376
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.2
 
 changeset:   4:5f4f3ceb285e
 parent:      0:5649c9d34dd8
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.1
 
 changeset:   3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3
 
 changeset:   2:d62976ca1e50
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.2
 
 changeset:   1:10b2180f755b
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.1
 
 changeset:   0:5649c9d34dd8
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.0
 
 ====== Pull ../full.hg into empty (with hook)
 changegroup hook: HG_NODE=5649c9d34dd87d0ecb5fd39672128376e83b22e1 HG_SOURCE=pull HG_URL=bundle:../full.hg 
 pulling from bundle://../full.hg
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 9 changesets with 7 changes to 4 files (+1 heads)
 (run 'hg heads' to see heads, 'hg merge' to merge)
 ====== Rollback empty
 rolling back last transaction
 ====== Log -R bundle:empty+full.hg
 8 7 6 5 4 3 2 1 0 
 ====== Pull full.hg into empty again (using -R; with hook)
 changegroup hook: HG_NODE=5649c9d34dd87d0ecb5fd39672128376e83b22e1 HG_SOURCE=pull HG_URL=bundle:empty+full.hg 
 pulling from full.hg
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 9 changesets with 7 changes to 4 files (+1 heads)
 (run 'hg heads' to see heads, 'hg merge' to merge)
 ====== Create partial clones
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 4 changesets with 4 changes to 1 files
 updating working directory
 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 updating working directory
 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 ====== Log -R full.hg in partial
 changeset:   8:836ac62537ab
 tag:         tip
 parent:      3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3m
 
 changeset:   7:80fe151401c2
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3m
 
 changeset:   6:1e3f6b843bd6
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3
 
 changeset:   5:024e4e7df376
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.2
 
 changeset:   4:5f4f3ceb285e
 parent:      0:5649c9d34dd8
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.1
 
 changeset:   3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3
 
 changeset:   2:d62976ca1e50
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.2
 
 changeset:   1:10b2180f755b
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.1
 
 changeset:   0:5649c9d34dd8
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.0
 
 ====== Incoming full.hg in partial
 comparing with bundle://../full.hg
 searching for changes
 changeset:   4:5f4f3ceb285e
 parent:      0:5649c9d34dd8
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.1
 
 changeset:   5:024e4e7df376
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.2
 
 changeset:   6:1e3f6b843bd6
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3
 
 changeset:   7:80fe151401c2
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3m
 
 changeset:   8:836ac62537ab
 tag:         tip
 parent:      3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3m
 
 ====== Outgoing -R full.hg vs partial2 in partial
 comparing with ../partial2
 searching for changes
 changeset:   4:5f4f3ceb285e
 parent:      0:5649c9d34dd8
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.1
 
 changeset:   5:024e4e7df376
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.2
 
 changeset:   6:1e3f6b843bd6
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3
 
 changeset:   7:80fe151401c2
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3m
 
 changeset:   8:836ac62537ab
 tag:         tip
 parent:      3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3m
 
 ====== Outgoing -R does-not-exist.hg vs partial2 in partial
 abort: No such file or directory: ../does-not-exist.hg
 ====== Direct clone from bundle (all-history)
 requesting all changes
 adding changesets
 adding manifests
 adding file changes
 added 9 changesets with 7 changes to 4 files (+1 heads)
 updating working directory
 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 changeset:   8:836ac62537ab
 tag:         tip
 parent:      3:ac69c658229d
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     0.3m
 
 changeset:   7:80fe151401c2
 user:        test
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     1.3m
 
 ====== Unbundle incremental bundles into fresh empty in one go
 1 changesets found
 1 changesets found
 adding changesets
 adding manifests
 adding file changes
 added 1 changesets with 1 changes to 1 files
 adding changesets
 adding manifests
 adding file changes
 added 1 changesets with 1 changes to 1 files
 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 ====== test for 540d1059c802
 updating working directory
 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 searching for changes
 1 changesets found
 comparing with ../bundle.hg
 searching for changes
 changeset:   2:ed1b79f46b9a
 tag:         tip
 parent:      0:bbd179dfa0a7
 user:        test
 date:        Thu Jan 01 00:00:00 1970 +0000
 summary:     change foo
 
+===== test that verify bundle does not traceback
+abort: 00changelog.i@bbd179dfa0a7: unknown parent!
+abort: cannot verify bundle or remote repos
+checking changesets
+checking manifests
+crosschecking files in changesets and manifests
+checking files
+2 files, 2 changesets, 2 total revisions