##// END OF EJS Templates
revset: point out wrong behavior in fullreposet...
Pierre-Yves David -
r25547:99a1f73a default
parent child Browse files
Show More
@@ -3541,6 +3541,17 b' class fullreposet(spanset):'
3541 # object.
3541 # object.
3542 other = baseset(other - self._hiddenrevs)
3542 other = baseset(other - self._hiddenrevs)
3543
3543
3544 # XXX As fullreposet is also used as bootstrap, this is wrong.
3545 #
3546 # With a giveme312() revset returning [3,1,2], this makes
3547 # 'hg log -r "giveme312()"' -> 1, 2, 3 (wrong)
3548 # We cannot just drop it because other usage still need to sort it:
3549 # 'hg log -r "all() and giveme312()"' -> 1, 2, 3 (right)
3550 #
3551 # There is also some faulty revset implementations that rely on it
3552 # (eg: children as of its state in e8075329c5fb)
3553 #
3554 # When we fix the two points above we can move this into the if clause
3544 other.sort(reverse=self.isdescending())
3555 other.sort(reverse=self.isdescending())
3545 return other
3556 return other
3546
3557
General Comments 0
You need to be logged in to leave comments. Login now