webcommands: move nonempty logic from JavaScript to Python

This avoids hard-coding the '(none)' string in the JavaScript for each
style and avoids the {nonexisting|nonempty} hack which only works
since the template system don't complain about undefined variables.

mercurial/hgweb/webcommands.py

@@ -646,7 +646,7 b' def graph(web, req, tmpl):'
         node = short(ctx.node())
         age = templatefilters.age(ctx.date())
         desc = templatefilters.firstline(ctx.description())
-        desc = cgi.escape(desc)
+        desc = cgi.escape(templatefilters.nonempty(desc))
         user = cgi.escape(templatefilters.person(ctx.user()))
         branch = ctx.branch()
         branch = branch, web.repo.branchtags().get(branch) == ctx.node()

templates/gitweb/graph.tmpl

@@ -78,10 +78,7 b' graph.vertex = function(x, y, color, par'
 	item = item.replace(/_PARITY/, 'parity' + parity);
 	item = item.replace(/_NODEID/, cur[0]);
 	item = item.replace(/_NODEID/, cur[0]);
-	if (cur[3] != '')
-	    item = item.replace(/_DESC/, cur[3]);
-	else
-	    item = item.replace(/_DESC/, '(none)');
+	item = item.replace(/_DESC/, cur[3]);
 	item = item.replace(/_USER/, cur[4]);
 	item = item.replace(/_DATE/, cur[5]);
 	

templates/monoblue/graph.tmpl

@@ -75,10 +75,7 b''
         item = item.replace(/_PARITY/, 'parity' + parity);
         item = item.replace(/_NODEID/, cur[0]);
         item = item.replace(/_NODEID/, cur[0]);
-        if (cur[3] != '')
-            item = item.replace(/_DESC/, cur[3]);
-        else
-            item = item.replace(/_DESC/, '(none)');
+	item = item.replace(/_DESC/, cur[3]);
         item = item.replace(/_USER/, cur[4]);
         item = item.replace(/_DATE/, cur[5]);
 

templates/paper/graph.tmpl

@@ -86,10 +86,7 b' graph.vertex = function(x, y, color, par'
 	item = item.replace(/_PARITY/, 'parity' + parity);
 	item = item.replace(/_NODEID/, cur[0]);
 	item = item.replace(/_NODEID/, cur[0]);
-	if (cur[3] != '')
-	    item = item.replace(/_DESC/, cur[3]);
-	else
-	    item = item.replace(/_DESC/, '(none)');
+	item = item.replace(/_DESC/, cur[3]);
 	item = item.replace(/_USER/, cur[4]);
 	item = item.replace(/_DATE/, cur[5]);
 

templates/spartan/graph.tmpl

@@ -70,10 +70,7 b' graph.vertex = function(x, y, color, par'
 	item = item.replace(/_PARITY/, 'parity' + parity);
 	item = item.replace(/_NODEID/, cur[0]);
 	item = item.replace(/_NODEID/, cur[0]);
-	if (cur[3] != '')
-	    item = item.replace(/_DESC/, cur[3]);
-	else
-	    item = item.replace(/_DESC/, '(none)');
+	item = item.replace(/_DESC/, cur[3]);
 	item = item.replace(/_USER/, cur[4]);
 	item = item.replace(/_DATE/, cur[5]);
 	

tests/test-hgweb-empty.out

@@ -230,10 +230,7 b' graph.vertex = function(x, y, color, par'
 	item = item.replace(/_PARITY/, 'parity' + parity);
 	item = item.replace(/_NODEID/, cur[0]);
 	item = item.replace(/_NODEID/, cur[0]);
-	if (cur[3] != '')
-	    item = item.replace(/_DESC/, cur[3]);
-	else
-	    item = item.replace(/_DESC/, '(none)');
+	item = item.replace(/_DESC/, cur[3]);
 	item = item.replace(/_USER/, cur[4]);
 	item = item.replace(/_DATE/, cur[5]);