core: don't hard-code hex node lengths

Differential Revision: https://phab.mercurial-scm.org/D10535

mercurial/localrepo.py

@@ -1861,7 +1861,7 b' class localrepository(object):'
                     changeid = hex(changeid)  # for the error message
                     raise
 
-            elif len(changeid) == 40:
+            elif len(changeid) == 2 * self.nodeconstants.nodelen:
                 node = bin(changeid)
                 rev = self.changelog.rev(node)
             else:

mercurial/revlog.py

@@ -1320,7 +1320,7 b' class revlog(object):'
             return self.node(rev)
         except (ValueError, OverflowError):
             pass
-        if len(id) == 40:
+        if len(id) == 2 * self.nodeconstants.nodelen:
             try:
                 # a full hex nodeid?
                 node = bin(id)

mercurial/revset.py

@@ -1724,7 +1724,7 b' def named(repo, subset, x):'
 def _node(repo, n):
     """process a node input"""
     rn = None
-    if len(n) == 40:
+    if len(n) == 2 * repo.nodeconstants.nodelen:
         try:
             rn = repo.changelog.rev(bin(n))
         except error.WdirUnsupported:

mercurial/scmutil.py

@@ -643,7 +643,7 b' def revsymbol(repo, symbol):'
         except (ValueError, OverflowError, IndexError):
             pass
 
-        if len(symbol) == 40:
+        if len(symbol) == 2 * repo.nodeconstants.nodelen:
             try:
                 node = bin(symbol)
                 rev = repo.changelog.rev(node)

mercurial/templatefuncs.py

@@ -764,9 +764,10 b' def shortest(context, mapping, args):'
         )
 
     repo = context.resource(mapping, b'repo')
-    if len(hexnode) > 40:
+    hexnodelen = 2 * repo.nodeconstants.nodelen
+    if len(hexnode) > hexnodelen:
         return hexnode
-    elif len(hexnode) == 40:
+    elif len(hexnode) == hexnodelen:
         try:
             node = bin(hexnode)
         except TypeError: