tag: lock before tagging

mercurial/commands.py

@@ -5501,7 +5501,10 b' def tag(ui, repo, name1, *names, **opts)'
 
     Returns 0 on success.
     """
-
+    wlock = lock = None
+    try:
+        wlock = repo.wlock()
+        lock = repo.lock()
     rev_ = "."
     names = [t.strip() for t in (name1,) + names]
     if len(names) != len(set(names)):
@@ -5510,7 +5513,8 b' def tag(ui, repo, name1, *names, **opts)'
         if n in ['tip', '.', 'null']:
             raise util.Abort(_("the name '%s' is reserved") % n)
         if not n:
-            raise util.Abort(_('tag names cannot consist entirely of whitespace'))
+                raise util.Abort(_('tag names cannot consist entirely of '
+                                   'whitespace'))
     if opts.get('rev') and opts.get('remove'):
         raise util.Abort(_("--rev and --remove are incompatible"))
     if opts.get('rev'):
@@ -5557,6 +5561,8 b' def tag(ui, repo, name1, *names, **opts)'
         message = ui.edit(message, ui.username())
 
     repo.tag(names, r, message, opts.get('local'), opts.get('user'), date)
+    finally:
+        release(lock, wlock)
 
 @command('tags', [], '')
 def tags(ui, repo):

tests/test-check-code-hg.t

@@ -320,9 +320,6 b''
    >             except:
    warning: naked except clause
   mercurial/commands.py:0:
-   >             raise util.Abort(_('tag names cannot consist entirely of whitespace'))
-   warning: line over 80 characters
-  mercurial/commands.py:0:
    >             ui.status(_("(run 'hg heads .' to see heads, 'hg merge' to merge)\n"))
    warning: line over 80 characters
   mercurial/commands.py:0: