mq: disallow # (and : on Windows) in patch names (issue2065)

hgext/mq.py

@@ -813,7 +813,8 b' class queue(object):'
     _reserved = ('series', 'status', 'guards')
     def check_reserved_name(self, name):
         if (name in self._reserved or name.startswith('.hg')
-            or name.startswith('.mq')):
+            or name.startswith('.mq') or '#' in name
+            or (os.name == 'nt' and ':' in name)):
             raise util.Abort(_('"%s" cannot be used as the name of a patch')
                              % name)
 

tests/test-mq-qnew

@@ -19,6 +19,8 b' runtest() {'
     hg qnew status
     hg qnew guards
     hg qnew .hgignore
+    hg qnew .mqfoo
+    hg qnew 'foo#bar'
 
     hg qinit -c
 

tests/test-mq-qnew.out

@@ -5,6 +5,8 b' abort: "series" cannot be used as the na'
 abort: "status" cannot be used as the name of a patch
 abort: "guards" cannot be used as the name of a patch
 abort: ".hgignore" cannot be used as the name of a patch
+abort: ".mqfoo" cannot be used as the name of a patch
+abort: "foo#bar" cannot be used as the name of a patch
 % qnew with uncommitted changes
 uncommitted.patch
 % qnew implies add
@@ -52,6 +54,8 b' abort: "series" cannot be used as the na'
 abort: "status" cannot be used as the name of a patch
 abort: "guards" cannot be used as the name of a patch
 abort: ".hgignore" cannot be used as the name of a patch
+abort: ".mqfoo" cannot be used as the name of a patch
+abort: "foo#bar" cannot be used as the name of a patch
 % qnew with uncommitted changes
 uncommitted.patch
 % qnew implies add