##// END OF EJS Templates
check-code: detect and ban 'util.Abort'...
Pierre-Yves David -
r26588:b3f7516f default
parent child Browse files
Show More
@@ -123,7 +123,8 b' testpats = ['
123 (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
123 (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
124 "put a backslash-escaped newline after sed 'i' command"),
124 "put a backslash-escaped newline after sed 'i' command"),
125 (r'^diff *-\w*u.*$\n(^ \$ |^$)', "prefix diff -u with cmp"),
125 (r'^diff *-\w*u.*$\n(^ \$ |^$)', "prefix diff -u with cmp"),
126 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py")
126 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
127 (r'\butil\.Abort\b', "directly use error.Abort"),
127 ],
128 ],
128 # warnings
129 # warnings
129 [
130 [
@@ -293,6 +294,7 b' pypats = ['
293 (r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),
294 (r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),
294 # XXX only catch mutable arguments on the first line of the definition
295 # XXX only catch mutable arguments on the first line of the definition
295 (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
296 (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
297 (r'\butil\.Abort\b', "directly use error.Abort"),
296 ],
298 ],
297 # warnings
299 # warnings
298 [
300 [
General Comments 0
You need to be logged in to leave comments. Login now