##// END OF EJS Templates
tests: avoid tab indent on all kinds of lines of sh commands
Mads Kiilerich -
r16497:c326fe88 stable
parent child Browse files
Show More
@@ -76,6 +76,7 b' testpats = ['
76 (r'if\s*!', "don't use '!' to negate exit status"),
76 (r'if\s*!', "don't use '!' to negate exit status"),
77 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
77 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
78 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
78 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
79 (r'^( *)\t', "don't use tabs to indent"),
79 ],
80 ],
80 # warnings
81 # warnings
81 []
82 []
@@ -87,7 +88,6 b' testfilters = ['
87 ]
88 ]
88
89
89 uprefix = r"^ \$ "
90 uprefix = r"^ \$ "
90 uprefixc = r"^ > "
91 utestpats = [
91 utestpats = [
92 [
92 [
93 (r'^(\S| $ ).*(\S[ \t]+|^[ \t]+)\n', "trailing whitespace on non-output"),
93 (r'^(\S| $ ).*(\S[ \t]+|^[ \t]+)\n', "trailing whitespace on non-output"),
@@ -98,7 +98,6 b' utestpats = ['
98 "explicit exit code checks unnecessary"),
98 "explicit exit code checks unnecessary"),
99 (uprefix + r'set -e', "don't use set -e"),
99 (uprefix + r'set -e', "don't use set -e"),
100 (uprefix + r'\s', "don't indent commands, use > for continued lines"),
100 (uprefix + r'\s', "don't indent commands, use > for continued lines"),
101 (uprefixc + r'( *)\t', "don't use tabs to indent"),
102 ],
101 ],
103 # warnings
102 # warnings
104 []
103 []
@@ -44,7 +44,7 b' for T in $TYPES ; do'
44 T2=`echo $T | tr [:upper:] [:lower:]`
44 T2=`echo $T | tr [:upper:] [:lower:]`
45 case $T in
45 case $T in
46 apple)
46 apple)
47 ;;
47 ;;
48 symlink*)
48 symlink*)
49 echo "this is target $T" >target_$T2
49 echo "this is target $T" >target_$T2
50 ln -s target_$T file_$T2
50 ln -s target_$T file_$T2
@@ -52,7 +52,7 b' for T in $TYPES ; do'
52 p4 add -t $T file_$T2
52 p4 add -t $T file_$T2
53 ;;
53 ;;
54 binary*)
54 binary*)
55 python -c "file('file_$T2', 'wb').write('this is $T')"
55 python -c "file('file_$T2', 'wb').write('this is $T')"
56 p4 add -t $T file_$T2
56 p4 add -t $T file_$T2
57 ;;
57 ;;
58 *)
58 *)
General Comments 0
You need to be logged in to leave comments. Login now