Commit username: Better error message, abort on empty name, fix documentation.

doc/hgrc.5.txt

@@ -401,8 +401,8 b' ui::'
   username;;
     The committer of a changeset created when running "commit".
     Typically a person's name and email address, e.g. "Fred Widget
-    <[e-mail]>".  Default is $EMAIL. If no default is found,
-    the username have to be specified manually.
+    <[e-mail]>".  Default is $EMAIL. If no default is found, or the
+    configured username is empty, it has to be specified manually.
   verbose;;
     Increase the amount of output printed.  True or False.  Default is False.
 

mercurial/ui.py

@@ -235,8 +235,13 b' class ui(object):'
             user = self.config("ui", "username")
         if user is None:
             user = os.environ.get("EMAIL")
-        if user is None:
-            raise util.Abort(_("No default username available, use -u"))
+        if not user:
+            self.status(_("Please choose a commit username to be recorded "
+                          "in the changelog via\ncommand line option "
+                          '(-u "First Last <[e-mail]>"), in the\n'
+                          "configuration files (hgrc), or by setting the "
+                          "EMAIL environment variable.\n\n"))
+            raise util.Abort(_("No commit username specified!"))
         return user
 
     def shortuser(self, user):

tests/test-committer.out

@@ -4,7 +4,11 b' user: My Name <[e-mail]'
 date:        Mon Jan 12 13:46:40 1970 +0000
 summary:     commit-1
 
-abort: No default username available, use -u
+Please choose a commit username to be recorded in the changelog via
+command line option (-u "First Last <[e-mail]>"), in the
+configuration files (hgrc), or by setting the EMAIL environment variable.
+
+abort: No commit username specified!
 transaction abort!
 rollback completed
 changeset:   1:2becd0bae6e6