config: simplify aliasing commands.update.check

experimental.updatecheck was renamed into commands.update.check, use the
config system to provides the fallback on the old config name instead of
adding more code.

Differential Revision: https://phab.mercurial-scm.org/D1117

mercurial/configitems.py

@@ -181,6 +181,8 b" coreconfigitem('commands', 'status.verbo"
 )
 coreconfigitem('commands', 'update.check',
     default=None,
+    # Deprecated, remove after 4.4 release
+    alias=[('experimental', 'updatecheck')]
 )
 coreconfigitem('commands', 'update.requiredest',
     default=False,
@@ -412,10 +414,6 b" coreconfigitem('experimental', 'spacemov"
 coreconfigitem('experimental', 'treemanifest',
     default=False,
 )
-# Deprecated, remove after 4.4 release
-coreconfigitem('experimental', 'updatecheck',
-    default=None,
-)
 coreconfigitem('extensions', '.*',
     default=None,
     generic=True,

mercurial/hg.py

@@ -758,9 +758,6 b' def updatetotally(ui, repo, checkout, br'
     """
     if updatecheck is None:
         updatecheck = ui.config('commands', 'update.check')
-        if updatecheck is None:
-            # pre-4.4 compat on the old spelling of this config item
-            updatecheck = ui.config('experimental', 'updatecheck')
         if updatecheck not in ('abort', 'none', 'linear', 'noconflict'):
             # If not configured, or invalid value configured
             updatecheck = 'linear'