check-code: warning and fixes for whitespace in unified tests

contrib/check-code.py

@@ -1,295 +1,296 b''
 #!/usr/bin/env python
 #
 # check-code - a style and portability checker for Mercurial
 #
 # Copyright 2010 Matt Mackall <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 import re, glob, os, sys
 import optparse
 
 def repquote(m):
     t = re.sub(r"\w", "x", m.group('text'))
     t = re.sub(r"[^\sx]", "o", t)
     return m.group('quote') + t + m.group('quote')
 
 def reppython(m):
     comment = m.group('comment')
     if comment:
         return "#" * len(comment)
     return repquote(m)
 
 def repcomment(m):
     return m.group(1) + "#" * len(m.group(2))
 
 def repccomment(m):
     t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))
     return m.group(1) + t + "*/"
 
 def repcallspaces(m):
     t = re.sub(r"\n\s+", "\n", m.group(2))
     return m.group(1) + t
 
 def repinclude(m):
     return m.group(1) + "<foo>"
 
 def rephere(m):
     t = re.sub(r"\S", "x", m.group(2))
     return m.group(1) + t
 
 
 testpats = [
     (r'(pushd|popd)', "don't use 'pushd' or 'popd', use 'cd'"),
     (r'\W\$?\(\([^\)]*\)\)', "don't use (()) or $(()), use 'expr'"),
     (r'^function', "don't use 'function', use old style"),
     (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
     (r'echo.*\\n', "don't use 'echo \\n', use printf"),
     (r'echo -n', "don't use 'echo -n', use printf"),
     (r'^diff.*-\w*N', "don't use 'diff -N'"),
     (r'(^| )wc[^|]*$', "filter wc output"),
     (r'head -c', "don't use 'head -c', use 'dd'"),
     (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
     (r'printf.*\\\d\d\d', "don't use 'printf \NNN', use Python"),
     (r'printf.*\\x', "don't use printf \\x, use Python"),
     (r'\$\(.*\)', "don't use $(expr), use `expr`"),
     (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
     (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
      "use egrep for extended grep syntax"),
     (r'/bin/', "don't use explicit paths for tools"),
     (r'\$PWD', "don't use $PWD, use `pwd`"),
     (r'[^\n]\Z', "no trailing newline"),
     (r'export.*=', "don't export and assign at once"),
     ('^([^"\']|("[^"]*")|(\'[^\']*\'))*\\^', "^ must be quoted"),
     (r'^source\b', "don't use 'source', use '.'"),
     (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
 ]
 
 testfilters = [
     (r"( *)(#([^\n]*\S)?)", repcomment),
     (r"<<(\S+)((.|\n)*?\n\1)", rephere),
 ]
 
 uprefix = r"^  \$ "
 uprefixc = r"^  > "
 utestpats = [
+    (r'^(\S|  $ ).*(\S\s+|^\s+)\n', "trailing whitespace on non-output"),
     (uprefix + r'.*\|\s*sed', "use regex test output patterns instead of sed"),
     (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
     (uprefix + r'.*\$\?', "explicit exit code checks unnecessary"),
     (uprefix + r'.*\|\| echo.*(fail|error)',
      "explicit exit code checks unnecessary"),
     (uprefix + r'set -e', "don't use set -e"),
     (uprefixc + r'( *)\t', "don't use tabs to indent"),
 ]
 
 for p, m in testpats:
     if p.startswith('^'):
         p = uprefix + p[1:]
     else:
         p = uprefix + p
     utestpats.append((p, m))
 
 utestfilters = [
     (r"( *)(#([^\n]*\S)?)", repcomment),
 ]
 
 pypats = [
     (r'^\s*def\s*\w+\s*\(.*,\s*\(',
      "tuple parameter unpacking not available in Python 3+"),
     (r'lambda\s*\(.*,.*\)',
      "tuple parameter unpacking not available in Python 3+"),
     (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),
     (r'\breduce\s*\(.*', "reduce is not available in Python 3+"),
     (r'\.has_key\b', "dict.has_key is not available in Python 3+"),
     (r'^\s*\t', "don't use tabs"),
     (r'\S;\s*\n', "semicolon"),
     (r'\w,\w', "missing whitespace after ,"),
     (r'\w[+/*\-<>]\w', "missing whitespace in expression"),
     (r'^\s+\w+=\w+[^,)]$', "missing whitespace in assignment"),
     (r'.{85}', "line too long"),
     (r'.{81}', "warning: line over 80 characters"),
     (r'[^\n]\Z', "no trailing newline"),
     (r'(\S\s+|^\s+)\n', "trailing whitespace"),
 #    (r'^\s+[^_ ][^_. ]+_[^_]+\s*=', "don't use underbars in identifiers"),
 #    (r'\w*[a-z][A-Z]\w*\s*=', "don't use camelcase in identifiers"),
     (r'^\s*(if|while|def|class|except|try)\s[^[]*:\s*[^\]#\s]+',
      "linebreak after :"),
     (r'class\s[^(]:', "old-style class, use class foo(object)"),
     (r'^\s+del\(', "del isn't a function"),
     (r'^\s+except\(', "except isn't a function"),
     (r',]', "unneeded trailing ',' in list"),
 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
 #     "don't capitalize non-exception classes"),
 #    (r'in range\(', "use xrange"),
 #    (r'^\s*print\s+', "avoid using print in core and extensions"),
     (r'[\x80-\xff]', "non-ASCII character literal"),
     (r'("\')\.format\(', "str.format() not available in Python 2.4"),
     (r'^\s*with\s+', "with not available in Python 2.4"),
     (r'(?<!def)\s+(any|all|format)\(',
      "any/all/format not available in Python 2.4"),
     (r'(?<!def)\s+(callable)\(',
      "callable not available in Python 3, use hasattr(f, '__call__')"),
     (r'if\s.*\selse', "if ... else form not available in Python 2.4"),
     (r'([\(\[]\s\S)|(\S\s[\)\]])', "gratuitous whitespace in () or []"),
 #    (r'\s\s=', "gratuitous whitespace before ="),
     (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=)\S',
      "missing whitespace around operator"),
     (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=)\s',
      "missing whitespace around operator"),
     (r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=)\S',
      "missing whitespace around operator"),
     (r'[^+=*!<>&| -](\s=|=\s)[^= ]',
      "wrong whitespace around ="),
     (r'raise Exception', "don't raise generic exceptions"),
     (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
      "warning: unwrapped ui message"),
 ]
 
 pyfilters = [
     (r"""(?msx)(?P<comment>\#.*?$)|
          ((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))
           (?P<text>(([^\\]|\\.)*?))
           (?P=quote))""", reppython),
 ]
 
 cpats = [
     (r'//', "don't use //-style comments"),
     (r'^  ', "don't use spaces to indent"),
     (r'\S\t', "don't use tabs except for indent"),
     (r'(\S\s+|^\s+)\n', "trailing whitespace"),
     (r'.{85}', "line too long"),
     (r'(while|if|do|for)\(', "use space after while/if/do/for"),
     (r'return\(', "return is not a function"),
     (r' ;', "no space before ;"),
     (r'\w+\* \w+', "use int *foo, not int* foo"),
     (r'\([^\)]+\) \w+', "use (int)foo, not (int) foo"),
     (r'\S+ (\+\+|--)', "use foo++, not foo ++"),
     (r'\w,\w', "missing whitespace after ,"),
     (r'\w[+/*]\w', "missing whitespace in expression"),
     (r'^#\s+\w', "use #foo, not # foo"),
     (r'[^\n]\Z', "no trailing newline"),
 ]
 
 cfilters = [
     (r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),
     (r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),
     (r'''(#\s*include\s+<)([^>]+)>''', repinclude),
     (r'(\()([^)]+\))', repcallspaces),
 ]
 
 checks = [
     ('python', r'.*\.(py|cgi)$', pyfilters, pypats),
     ('test script', r'(.*/)?test-[^.~]*$', testfilters, testpats),
     ('c', r'.*\.c$', cfilters, cpats),
     ('unified test', r'.*\.t$', utestfilters, utestpats),
 ]
 
 class norepeatlogger(object):
     def __init__(self):
         self._lastseen = None
 
     def log(self, fname, lineno, line, msg, blame):
         """print error related a to given line of a given file.
 
         The faulty line will also be printed but only once in the case
         of multiple errors.
 
         :fname: filename
         :lineno: line number
         :line: actual content of the line
         :msg: error message
         """
         msgid = fname, lineno, line
         if msgid != self._lastseen:
             if blame:
                 print "%s:%d (%s):" % (fname, lineno, blame)
             else:
                 print "%s:%d:" % (fname, lineno)
             print " > %s" % line
             self._lastseen = msgid
         print " " + msg
 
 _defaultlogger = norepeatlogger()
 
 def getblame(f):
     lines = []
     for l in os.popen('hg annotate -un %s' % f):
         start, line = l.split(':', 1)
         user, rev = start.split()
         lines.append((line[1:-1], user, rev))
     return lines
 
 def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,
               blame=False):
     """checks style and portability of a given file
 
     :f: filepath
     :logfunc: function used to report error
               logfunc(filename, linenumber, linecontent, errormessage)
     :maxerr: number of error to display before arborting.
              Set to None (default) to report all errors
 
     return True if no error is found, False otherwise.
     """
     blamecache = None
     result = True
     for name, match, filters, pats in checks:
         fc = 0
         if not re.match(match, f):
             continue
         pre = post = open(f).read()
         if "no-" + "check-code" in pre:
             break
         for p, r in filters:
             post = re.sub(p, r, post)
         # print post # uncomment to show filtered version
         z = enumerate(zip(pre.splitlines(), post.splitlines(True)))
         for n, l in z:
             if "check-code" + "-ignore" in l[0]:
                 continue
             for p, msg in pats:
                 if not warnings and msg.startswith("warning"):
                     continue
                 if re.search(p, l[1]):
                     bd = ""
                     if blame:
                         bd = 'working directory'
                         if not blamecache:
                             blamecache = getblame(f)
                         if n < len(blamecache):
                             bl, bu, br = blamecache[n]
                             if bl == l[0]:
                                 bd = '%s@%s' % (bu, br)
                     logfunc(f, n + 1, l[0], msg, bd)
                     fc += 1
                     result = False
             if maxerr is not None and fc >= maxerr:
                 print " (too many errors, giving up)"
                 break
         break
     return result
 
 if __name__ == "__main__":
     parser = optparse.OptionParser("%prog [options] [files]")
     parser.add_option("-w", "--warnings", action="store_true",
                       help="include warning-level checks")
     parser.add_option("-p", "--per-file", type="int",
                       help="max warnings per file")
     parser.add_option("-b", "--blame", action="store_true",
                       help="use annotate to generate blame info")
 
     parser.set_defaults(per_file=15, warnings=False, blame=False)
     (options, args) = parser.parse_args()
 
     if len(args) == 0:
         check = glob.glob("*")
     else:
         check = args
 
     for f in check:
         ret = 0
         if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,
                          blame=options.blame):
             ret = 1
     sys.exit(ret)

tests/test-convert-cvs-branch.t

@@ -1,192 +1,192 b''
 This is http://mercurial.selenic.com/bts/issue1148
 and http://mercurial.selenic.com/bts/issue1447
 
   $ "$TESTDIR/hghave" cvs || exit 80
   $ cvscall()
   > {
   >     cvs -f "$@" > /dev/null
   > }
   $ echo "[extensions]" >> $HGRCPATH
   $ echo "convert = " >> $HGRCPATH
   $ echo "graphlog = " >> $HGRCPATH
   $ echo "[convert]" >> $HGRCPATH
   $ echo "cvsps.cache=0" >> $HGRCPATH
 
 create cvs repository
 
   $ mkdir cvsrepo
   $ cd cvsrepo
   $ CVSROOT=`pwd`
   $ export CVSROOT
   $ CVS_OPTIONS=-f
   $ export CVS_OPTIONS
   $ cd ..
   $ cvscall -q -d "$CVSROOT" init
 
 Create a new project
 
   $ mkdir src
   $ cd src
   $ echo "1" > a
   $ echo "1" > b
   $ cvscall import -m "init" src v0 r0 | sort
   $ cd ..
   $ cvscall co src
   cvs checkout: Updating src
   $ cd src
 
 Branch the project
 
   $ cvscall tag -b BRANCH
   cvs tag: Tagging .
   $ cvscall up -r BRANCH > /dev/null
   cvs update: Updating .
 
-Modify file a, then b, then a 
+Modify file a, then b, then a
 
   $ sleep 1
   $ echo "2" > a
   $ cvscall ci -m "mod a"
   cvs commit: Examining .
   $ echo "2" > b
   $ cvscall ci -m "mod b"
   cvs commit: Examining .
   $ sleep 1
   $ echo "3" > a
   $ cvscall ci -m "mod a again"
   cvs commit: Examining .
 
 Convert
 
   $ cd ..
   $ hg convert src
   assuming destination src-hg
   initializing destination src-hg repository
   connecting to $TESTTMP/cvsrepo
   scanning source...
   collecting CVS rlog
   7 log entries
   creating changesets
   5 changeset entries
   sorting...
   converting...
   4 Initial revision
   3 init
   2 mod a
   1 mod b
   0 mod a again
   updating tags
 
 Check the result
 
   $ hg -R src-hg glog --template '{rev} ({branches}) {desc} files: {files}\n'
   o  5 () update tags files: .hgtags
   |
   | o  4 (BRANCH) mod a again files: a
   | |
   | o  3 (BRANCH) mod b files: b
   | |
   | o  2 (BRANCH) mod a files: a
   | |
   | o  1 (v0) init files:
   |/
   o  0 () Initial revision files: a b
   
 
 
 issue 1447
 
   $ cvscall()
   > {
   >     cvs -f "$@" > /dev/null
   >     sleep 1
   > }
   $ cvsci()
   > {
   >     cvs -f ci "$@" >/dev/null
   >     sleep 1
   > }
   $ cvscall -Q -d `pwd`/cvsmaster2 init
   $ cd cvsmaster2
   $ CVSROOT=`pwd`
   $ export CVSROOT
   $ mkdir foo
   $ cd ..
   $ cvscall -Q co -d cvswork2 foo
   $ cd cvswork2
   $ echo foo > a.txt
   $ echo bar > b.txt
   $ cvscall -Q add a.txt b.txt
   $ cvsci -m "Initial commit"
   cvs commit: Examining .
   $ echo foo > b.txt
   $ cvsci -m "Fix b on HEAD"
   cvs commit: Examining .
   $ echo bar > a.txt
   $ cvsci -m "Small fix in a on HEAD"
   cvs commit: Examining .
   $ cvscall -Q tag -b BRANCH
   $ cvscall -Q up -P -rBRANCH
   $ echo baz > b.txt
   $ cvsci -m "Change on BRANCH in b"
   cvs commit: Examining .
   $ hg debugcvsps -x --parents foo
   collecting CVS rlog
   5 log entries
   creating changesets
   4 changeset entries
   ---------------------
   PatchSet 1 
   Date: * (glob)
   Author: * (glob)
   Branch: HEAD
   Tag: (none) 
   Log:
   Initial commit
   
   Members: 
   	a.txt:INITIAL->1.1 
   	b.txt:INITIAL->1.1 
   
   ---------------------
   PatchSet 2 
   Date: * (glob)
   Author: * (glob)
   Branch: HEAD
   Tag: (none) 
   Branchpoints: BRANCH 
   Parent: 1
   Log:
   Fix b on HEAD
   
   Members: 
   	b.txt:1.1->1.2 
   
   ---------------------
   PatchSet 3 
   Date: * (glob)
   Author: * (glob)
   Branch: HEAD
   Tag: (none) 
   Branchpoints: BRANCH 
   Parent: 2
   Log:
   Small fix in a on HEAD
   
   Members: 
   	a.txt:1.1->1.2 
   
   ---------------------
   PatchSet 4 
   Date: * (glob)
   Author: * (glob)
   Branch: BRANCH
   Tag: (none) 
   Parent: 3
   Log:
   Change on BRANCH in b
   
   Members: 
   	b.txt:1.2->1.2.2.1 
   
 

tests/test-push-warn.t

@@ -1,701 +1,701 b''
   $ echo "[extensions]" >> $HGRCPATH
   $ echo "graphlog=" >> $HGRCPATH
 
   $ mkdir a
   $ cd a
   $ hg init
   $ echo foo > t1
   $ hg add t1
   $ hg commit -m "1"
 
   $ cd ..
   $ hg clone a b
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ cd a
   $ echo foo > t2
   $ hg add t2
   $ hg commit -m "2"
 
   $ cd ../b
   $ echo foo > t3
   $ hg add t3
   $ hg commit -m "3"
 
   $ hg push ../a
   pushing to ../a
   searching for changes
   abort: push creates new remote heads on branch 'default'!
   (you should pull and merge or use push -f to force)
   [255]
 
   $ hg pull ../a
   pulling from ../a
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (+1 heads)
   (run 'hg heads' to see heads, 'hg merge' to merge)
 
   $ hg push ../a
   pushing to ../a
   searching for changes
   abort: push creates new remote heads on branch 'default'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg merge
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
 
   $ hg commit -m "4"
   $ hg push ../a
   pushing to ../a
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 1 changes to 1 files
 
   $ cd ..
 
   $ hg init c
   $ cd c
   $ for i in 0 1 2; do
   >     echo $i >> foo
   >     hg ci -Am $i
   > done
   adding foo
   $ cd ..
 
   $ hg clone c d
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ cd d
   $ for i in 0 1; do
   >    hg co -C $i
   >    echo d-$i >> foo
   >    hg ci -m d-$i
   > done
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   created new head
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   created new head
 
   $ HGMERGE=true hg merge 3
   merging foo
   0 files updated, 1 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
 
   $ hg ci -m c-d
 
   $ hg push ../c
   pushing to ../c
   searching for changes
   abort: push creates new remote heads on branch 'default'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push -r 2 ../c
   pushing to ../c
   searching for changes
   no changes found
 
   $ hg push -r 3 ../c
   pushing to ../c
   searching for changes
   abort: push creates new remote heads on branch 'default'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push -r 3 -r 4 ../c
   pushing to ../c
   searching for changes
   abort: push creates new remote heads on branch 'default'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push -f -r 3 -r 4 ../c
   pushing to ../c
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 2 changes to 1 files (+2 heads)
 
   $ hg push -r 5 ../c
   pushing to ../c
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (-1 heads)
 
   $ hg in ../c
   comparing with ../c
   searching for changes
   no changes found
   [1]
 
 
 Issue450: push -r warns about remote head creation even if no heads
 will be created
 
   $ hg init ../e
   $ hg push -r 0 ../e
   pushing to ../e
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
   $ hg push -r 1 ../e
   pushing to ../e
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
   $ cd ..
 
 
 Issue736: named branches are not considered for detection of
 unmerged heads in "hg push"
 
   $ hg init f
   $ cd f
   $ hg -q branch a
   $ echo 0 > foo
   $ hg -q ci -Am 0
   $ echo 1 > foo
   $ hg -q ci -m 1
   $ hg -q up 0
   $ echo 2 > foo
   $ hg -q ci -m 2
   $ hg -q up 0
   $ hg -q branch b
   $ echo 3 > foo
   $ hg -q ci -m 3
   $ cd ..
 
   $ hg -q clone f g
   $ cd g
 
 Push on existing branch and new branch:
 
   $ hg -q up 1
   $ echo 4 > foo
   $ hg -q ci -m 4
   $ hg -q up 0
   $ echo 5 > foo
   $ hg -q branch c
   $ hg -q ci -m 5
 
   $ hg push ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ hg push -r 4 -r 5 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
 
 Multiple new branches:
 
   $ hg -q branch d
   $ echo 6 > foo
   $ hg -q ci -m 6
 
   $ hg push ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c, d!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ hg push -r 4 -r 6 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c, d!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ cd ../g
 
 
 Fail on multiple head push:
 
   $ hg -q up 1
   $ echo 7 > foo
   $ hg -q ci -m 7
 
   $ hg push -r 4 -r 7 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote heads on branch 'a'!
   (did you forget to merge? use push -f to force)
   [255]
 
 Push replacement head on existing branches:
 
   $ hg -q up 3
   $ echo 8 > foo
   $ hg -q ci -m 8
 
   $ hg push -r 7 -r 8 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 2 changes to 1 files
 
 
 Merge of branch a to other branch b followed by unrelated push
 on branch a:
 
   $ hg -q up 7
   $ HGMERGE=true hg -q merge 8
   $ hg -q ci -m 9
   $ hg -q up 8
   $ echo 10 > foo
   $ hg -q ci -m 10
 
   $ hg push -r 9 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (-1 heads)
 
   $ hg push -r 10 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (+1 heads)
 
 
 Cheating the counting algorithm:
 
   $ hg -q up 9
   $ HGMERGE=true hg -q merge 2
   $ hg -q ci -m 11
   $ hg -q up 1
   $ echo 12 > foo
   $ hg -q ci -m 12
 
   $ hg push -r 11 -r 12 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 2 changes to 1 files
 
 
 Failed push of new named branch:
 
   $ echo 12 > foo
   $ hg -q ci -m 12a
   [1]
   $ hg -q up 11
   $ echo 13 > foo
   $ hg -q branch e
   $ hg -q ci -m 13d
 
   $ hg push -r 12 -r 13 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: e!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
 
 Using --new-branch to push new named branch:
 
   $ hg push --new-branch -r 12 -r 13 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
 
-Checking prepush logic does not allow silently pushing 
+Checking prepush logic does not allow silently pushing
 multiple new heads:
 
   $ cd ..
   $ hg init h
   $ echo init > h/init
   $ hg -R h ci -Am init
   adding init
   $ echo a > h/a
   $ hg -R h ci -Am a
   adding a
   $ hg clone h i
   updating to branch default
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ hg -R h up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo b > h/b
   $ hg -R h ci -Am b
   adding b
   created new head
   $ hg -R i up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo c > i/c
   $ hg -R i ci -Am c
   adding c
   created new head
 
   $ hg -R i push h
   pushing to h
   searching for changes
   abort: push creates new remote heads on branch 'default'!
   (you should pull and merge or use push -f to force)
   [255]
 
 
 Check prepush logic with merged branches:
 
   $ hg init j
   $ hg -R j branch a
   marked working directory as branch a
   $ echo init > j/foo
   $ hg -R j ci -Am init
   adding foo
   $ hg clone j k
   updating to branch a
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ echo a1 > j/foo
   $ hg -R j ci -m a1
   $ hg -R k branch b
   marked working directory as branch b
   $ echo b > k/foo
   $ hg -R k ci -m b
   $ hg -R k up 0
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ hg -R k merge b
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
 
   $ hg -R k ci -m merge
 
   $ hg -R k push -r a j
   pushing to j
   searching for changes
   abort: push creates new remote branches: b!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
 
 Prepush -r should not allow you to sneak in new heads:
 
   $ hg init l
   $ cd l
   $ echo a >> foo
   $ hg -q add foo
   $ hg -q branch a
   $ hg -q ci -ma
   $ hg -q up null
   $ echo a >> foo
   $ hg -q add foo
   $ hg -q branch b
   $ hg -q ci -mb
   $ cd ..
   $ hg -q clone l m -u a
   $ cd m
   $ hg -q merge b
   $ hg -q ci -mmb
   $ hg -q up 0
   $ echo a >> foo
   $ hg -q ci -ma2
   $ hg -q up 2
   $ echo a >> foo
   $ hg -q branch -f b
   $ hg -q ci -mb2
   $ hg -q merge 3
   $ hg -q ci -mma
 
   $ hg push ../l -b b
   pushing to ../l
   searching for changes
   abort: push creates new remote heads on branch 'a'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ cd ..
 
 
 Check prepush with new branch head on former topo non-head:
 
   $ hg init n
   $ cd n
   $ hg branch A
   marked working directory as branch A
   $ echo a >a
   $ hg ci -Ama
   adding a
   $ hg branch B
   marked working directory as branch B
   $ echo b >b
   $ hg ci -Amb
   adding b
 
 b is now branch head of B, and a topological head
 a is now branch head of A, but not a topological head
 
   $ hg clone . inner
   updating to branch B
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd inner
   $ hg up B
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ echo b1 >b1
   $ hg ci -Amb1
   adding b1
 
 in the clone b1 is now the head of B
 
   $ cd ..
   $ hg up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo a2 >a2
   $ hg ci -Ama2
   adding a2
 
-a2 is now the new branch head of A, and a new topological head 
+a2 is now the new branch head of A, and a new topological head
 it replaces a former inner branch head, so it should at most warn about
 A, not B
 
 glog of local:
 
   $ hg glog --template "{rev}: {branches} {desc}\n"
   @  2: A a2
   |
   | o  1: B b
   |/
   o  0: A a
   
 glog of remote:
 
   $ hg glog -R inner --template "{rev}: {branches} {desc}\n"
   @  2: B b1
   |
   o  1: B b
   |
   o  0: A a
   
 outgoing:
 
   $ hg out inner --template "{rev}: {branches} {desc}\n"
   comparing with inner
   searching for changes
   2: A a2
 
   $ hg push inner
   pushing to inner
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (+1 heads)
 
   $ cd ..
 
 
 Check prepush with new branch head on former topo head:
 
   $ hg init o
   $ cd o
   $ hg branch A
   marked working directory as branch A
   $ echo a >a
   $ hg ci -Ama
   adding a
   $ hg branch B
   marked working directory as branch B
   $ echo b >b
   $ hg ci -Amb
   adding b
 
 b is now branch head of B, and a topological head
 
   $ hg up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo a1 >a1
   $ hg ci -Ama1
   adding a1
 
 a1 is now branch head of A, and a topological head
 
   $ hg clone . inner
   updating to branch A
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd inner
   $ hg up B
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo b1 >b1
   $ hg ci -Amb1
   adding b1
 
 in the clone b1 is now the head of B
 
   $ cd ..
   $ echo a2 >a2
   $ hg ci -Ama2
   adding a2
 
 a2 is now the new branch head of A, and a topological head
 it replaces a former topological and branch head, so this should not warn
 
 glog of local:
 
   $ hg glog --template "{rev}: {branches} {desc}\n"
   @  3: A a2
   |
   o  2: A a1
   |
   | o  1: B b
   |/
   o  0: A a
   
 glog of remote:
 
   $ hg glog -R inner --template "{rev}: {branches} {desc}\n"
   @  3: B b1
   |
   | o  2: A a1
   | |
   o |  1: B b
   |/
   o  0: A a
   
 outgoing:
 
   $ hg out inner --template "{rev}: {branches} {desc}\n"
   comparing with inner
   searching for changes
   3: A a2
 
   $ hg push inner
   pushing to inner
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
   $ cd ..
 
 
 Check prepush with new branch head and new child of former branch head
 but child is on different branch:
 
   $ hg init p
   $ cd p
   $ hg branch A
   marked working directory as branch A
   $ echo a0 >a
   $ hg ci -Ama0
   adding a
   $ echo a1 >a
   $ hg ci -ma1
   $ hg up null
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg branch B
   marked working directory as branch B
   $ echo b0 >b
   $ hg ci -Amb0
   adding b
   $ echo b1 >b
   $ hg ci -mb1
 
   $ hg clone . inner
   updating to branch B
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ hg up A
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg branch -f B
   marked working directory as branch B
   $ echo a3 >a
   $ hg ci -ma3
   created new head
   $ hg up 3
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg branch -f A
   marked working directory as branch A
   $ echo b3 >b
   $ hg ci -mb3
   created new head
 
 glog of local:
 
   $ hg glog --template "{rev}: {branches} {desc}\n"
   @  5: A b3
   |
   | o  4: B a3
   | |
   o |  3: B b1
   | |
   o |  2: B b0
    /
   o  1: A a1
   |
   o  0: A a0
   
 glog of remote:
 
   $ hg glog -R inner --template "{rev}: {branches} {desc}\n"
   @  3: B b1
   |
   o  2: B b0
   
   o  1: A a1
   |
   o  0: A a0
   
 outgoing:
 
   $ hg out inner --template "{rev}: {branches} {desc}\n"
   comparing with inner
   searching for changes
   4: B a3
   5: A b3
 
   $ hg push inner
   pushing to inner
   searching for changes
   abort: push creates new remote heads on branch 'A'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push inner -r4 -r5
   pushing to inner
   searching for changes
   abort: push creates new remote heads on branch 'A'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg in inner
   comparing with inner
   searching for changes
   no changes found
   [1]

tests/test-rebase-mq-skip.t

@@ -1,136 +1,136 b''
-This emulates the effects of an hg pull --rebase in which the remote repo 
+This emulates the effects of an hg pull --rebase in which the remote repo
 already has one local mq patch
 
   $ cat >> $HGRCPATH <<EOF
   > [extensions]
   > graphlog=
   > rebase=
   > mq=
   > 
   > [alias]
   > tglog = log -G --template "{rev}: '{desc}' tags: {tags}\n"
   > EOF
 
 
   $ hg init a
   $ cd a
   $ hg qinit -c
 
   $ echo c1 > c1
   $ hg add c1
   $ hg ci -m C1
 
   $ echo r1 > r1
   $ hg add r1
   $ hg ci -m R1
 
   $ hg up -q 0
 
   $ hg qnew p0.patch
   $ echo p0 > p0
   $ hg add p0
   $ hg qref -m P0
 
   $ hg qnew p1.patch
   $ echo p1 > p1
   $ hg add p1
   $ hg qref -m P1
 
   $ hg export qtip > p1.patch 
 
   $ hg up -q -C 1
 
   $ hg import p1.patch
   applying p1.patch
 
   $ rm p1.patch
 
   $ hg up -q -C qtip
 
   $ hg rebase
   saved backup bundle to $TESTTMP/a/.hg/strip-backup/*-backup.hg (glob)
 
   $ hg tglog
   @  3: 'P0' tags: p0.patch qbase qtip tip
   |
   o  2: 'P1' tags: qparent
   |
   o  1: 'R1' tags:
   |
   o  0: 'C1' tags:
   
   $ cd ..
 
 
   $ hg init b
   $ cd b
   $ hg qinit -c
 
   $ for i in r0 r1 r2 r3 r4 r5 r6;
   > do
   >     echo $i > $i
   >     hg ci -Am $i
   > done
   adding r0
   adding r1
   adding r2
   adding r3
   adding r4
   adding r5
   adding r6
 
   $ hg qimport -r 1:tip
 
   $ hg up -q 0
 
   $ for i in r1 r3 r7 r8;
   > do
   >     echo $i > $i
   >     hg ci -Am branch2-$i
   > done
   adding r1
   created new head
   adding r3
   adding r7
   adding r8
 
   $ echo somethingelse > r4
   $ hg ci -Am branch2-r4
   adding r4
 
   $ echo r6 > r6
   $ hg ci -Am branch2-r6
   adding r6
 
   $ hg up -q qtip
 
   $ HGMERGE=internal:fail hg rebase
   abort: fix unresolved conflicts with hg resolve then run hg rebase --continue
   [255]
 
   $ HGMERGE=internal:local hg resolve --all
 
   $ hg rebase --continue
   saved backup bundle to $TESTTMP/b/.hg/strip-backup/*-backup.hg (glob)
 
   $ hg tglog
   @  9: 'r5' tags: 5.diff qtip tip
   |
   o  8: 'r4' tags: 4.diff
   |
   o  7: 'r2' tags: 2.diff qbase
   |
   o  6: 'branch2-r6' tags: qparent
   |
   o  5: 'branch2-r4' tags:
   |
   o  4: 'branch2-r8' tags:
   |
   o  3: 'branch2-r7' tags:
   |
   o  2: 'branch2-r3' tags:
   |
   o  1: 'branch2-r1' tags:
   |
   o  0: 'r0' tags: