Show More
@@ -101,9 +101,9 b' impl<G: Graph> AncestorsIterator<G> {' | |||||
101 | /// |
|
101 | /// | |
102 | /// - there's no filtering of invalid parent revisions. Actually, it should be |
|
102 | /// - there's no filtering of invalid parent revisions. Actually, it should be | |
103 | /// consistent and more efficient to filter them from the end caller. |
|
103 | /// consistent and more efficient to filter them from the end caller. | |
104 | /// - we don't have the optimization for adjacent revs |
|
104 | /// - we don't have the optimization for adjacent revisions (i.e., the case | |
105 |
/// |
|
105 | /// where `p1 == rev - 1`), because it amounts to update the first element of | |
106 |
/// |
|
106 | /// the heap without sifting, which Rust's BinaryHeap doesn't let us do. | |
107 | /// - we save a few pushes by comparing with `stoprev` before pushing |
|
107 | /// - we save a few pushes by comparing with `stoprev` before pushing | |
108 | impl<G: Graph> Iterator for AncestorsIterator<G> { |
|
108 | impl<G: Graph> Iterator for AncestorsIterator<G> { | |
109 | type Item = Result<Revision, GraphError>; |
|
109 | type Item = Result<Revision, GraphError>; |
General Comments 0
You need to be logged in to leave comments.
Login now