tests: correct the remaining fallout from recent path style changes on Windows

Per @martinvonz, `ui.slash` set by the test runner is now capable of playing a
more active role.[1]  I verified that both of these work by setting `ui.slash`
to False, but these changes seem cleaner.  The problem with check-perf-code.py
was that the proper imports were not being whitelisted due to '\' vs '/'.

[1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-February/128701.html

tests/check-perf-code.py

@@ -1,79 +1,79 b''
 #!/usr/bin/env python
 #
 # check-perf-code - (historical) portability checker for contrib/perf.py
 
 from __future__ import absolute_import
 
 import os
 import sys
 
 # write static check patterns here
 perfpypats = [
   [
     (r'(branchmap|repoview)\.subsettable',
      "use getbranchmapsubsettable() for early Mercurial"),
     (r'\.(vfs|svfs|opener|sopener)',
      "use getvfs()/getsvfs() for early Mercurial"),
     (r'ui\.configint',
      "use getint() instead of ui.configint() for early Mercurial"),
   ],
   # warnings
   [
   ]
 ]
 
 def modulewhitelist(names):
     replacement = [('.py', ''), ('.c', ''), # trim suffix
-                   ('mercurial%s' % (os.sep), ''), # trim "mercurial/" path
+                   ('mercurial%s' % ('/'), ''), # trim "mercurial/" path
                   ]
     ignored = {'__init__'}
     modules = {}
 
     # convert from file name to module name, and count # of appearances
     for name in names:
         name = name.strip()
         for old, new in replacement:
             name = name.replace(old, new)
         if name not in ignored:
             modules[name] = modules.get(name, 0) + 1
 
     # list up module names, which appear multiple times
     whitelist = []
     for name, count in modules.items():
         if count > 1:
             whitelist.append(name)
 
     return whitelist
 
 if __name__ == "__main__":
     # in this case, it is assumed that result of "hg files" at
     # multiple revisions is given via stdin
     whitelist = modulewhitelist(sys.stdin)
     assert whitelist, "module whitelist is empty"
 
     # build up module whitelist check from file names given at runtime
     perfpypats[0].append(
         # this matching pattern assumes importing modules from
         # "mercurial" package in the current style below, for simplicity
         #
         #    from mercurial import (
         #        foo,
         #        bar,
         #        baz
         #    )
         ((r'from mercurial import [(][a-z0-9, \n#]*\n(?! *%s,|^[ #]*\n|[)])'
           % ',| *'.join(whitelist)),
          "import newer module separately in try clause for early Mercurial"
          ))
 
     # import contrib/check-code.py as checkcode
     assert 'RUNTESTDIR' in os.environ, "use check-perf-code.py in *.t script"
     contribpath = os.path.join(os.environ['RUNTESTDIR'], '..', 'contrib')
     sys.path.insert(0, contribpath)
     checkcode = __import__('check-code')
 
     # register perf.py specific entry with "checks" in check-code.py
     checkcode.checks.append(('perf.py', r'contrib/perf.py$', '',
                              checkcode.pyfilters, perfpypats))
 
     sys.exit(checkcode.main())

tests/test-hgignore.t

@@ -1,363 +1,363 b''
   $ hg init ignorerepo
   $ cd ignorerepo
 
 debugignore with no hgignore should be deterministic:
   $ hg debugignore
   <nevermatcher>
 
 Issue562: .hgignore requires newline at end:
 
   $ touch foo
   $ touch bar
   $ touch baz
   $ cat > makeignore.py <<EOF
   > f = open(".hgignore", "w")
   > f.write("ignore\n")
   > f.write("foo\n")
   > # No EOL here
   > f.write("bar")
   > f.close()
   > EOF
 
   $ "$PYTHON" makeignore.py
 
 Should display baz only:
 
   $ hg status
   ? baz
 
   $ rm foo bar baz .hgignore makeignore.py
 
   $ touch a.o
   $ touch a.c
   $ touch syntax
   $ mkdir dir
   $ touch dir/a.o
   $ touch dir/b.o
   $ touch dir/c.o
 
   $ hg add dir/a.o
   $ hg commit -m 0
   $ hg add dir/b.o
 
   $ hg status
   A dir/b.o
   ? a.c
   ? a.o
   ? dir/c.o
   ? syntax
 
   $ echo "*.o" > .hgignore
   $ hg status
   abort: $TESTTMP/ignorerepo/.hgignore: invalid pattern (relre): *.o (glob)
   [255]
 
 Ensure given files are relative to cwd
 
   $ echo "dir/.*\.o" > .hgignore
   $ hg status -i
   I dir/c.o
 
   $ hg debugignore dir/c.o dir/missing.o
   dir/c.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 1: 'dir/.*\.o') (glob)
   dir/missing.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 1: 'dir/.*\.o') (glob)
   $ cd dir
   $ hg debugignore c.o missing.o
   c.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 1: 'dir/.*\.o') (glob)
   missing.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 1: 'dir/.*\.o') (glob)
 
 For icasefs, inexact matches also work, except for missing files
 
 #if icasefs
   $ hg debugignore c.O missing.O
   c.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 1: 'dir/.*\.o') (glob)
   missing.O is not ignored
 #endif
 
   $ cd ..
 
   $ echo ".*\.o" > .hgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? syntax
 
 Ensure that comments work:
 
   $ touch 'foo#bar' 'quux#'
 #if no-windows
   $ touch 'baz\#wat'
 #endif
   $ cat <<'EOF' >> .hgignore
   > # full-line comment
   >   # whitespace-only comment line
   > syntax# pattern, no whitespace, then comment
   > a.c  # pattern, then whitespace, then comment
   > baz\\# # escaped comment character
   > foo\#b # escaped comment character
   > quux\## escaped comment character at end of name
   > EOF
   $ hg status
   A dir/b.o
   ? .hgignore
   $ rm 'foo#bar' 'quux#'
 #if no-windows
   $ rm 'baz\#wat'
 #endif
 
 Check that '^\.' does not ignore the root directory:
 
   $ echo "^\." > .hgignore
   $ hg status
   A dir/b.o
   ? a.c
   ? a.o
   ? dir/c.o
   ? syntax
 
 Test that patterns from ui.ignore options are read:
 
   $ echo > .hgignore
   $ cat >> $HGRCPATH << EOF
   > [ui]
   > ignore.other = $TESTTMP/ignorerepo/.hg/testhgignore
   > EOF
   $ echo "glob:**.o" > .hg/testhgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? syntax
 
 empty out testhgignore
   $ echo > .hg/testhgignore
 
 Test relative ignore path (issue4473):
 
   $ cat >> $HGRCPATH << EOF
   > [ui]
   > ignore.relative = .hg/testhgignorerel
   > EOF
   $ echo "glob:*.o" > .hg/testhgignorerel
   $ cd dir
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? syntax
 
   $ cd ..
   $ echo > .hg/testhgignorerel
   $ echo "syntax: glob" > .hgignore
   $ echo "re:.*\.o" >> .hgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? syntax
 
   $ echo "syntax: invalid" > .hgignore
   $ hg status
   $TESTTMP/ignorerepo/.hgignore: ignoring invalid syntax 'invalid'
   A dir/b.o
   ? .hgignore
   ? a.c
   ? a.o
   ? dir/c.o
   ? syntax
 
   $ echo "syntax: glob" > .hgignore
   $ echo "*.o" >> .hgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? syntax
 
   $ echo "relglob:syntax*" > .hgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? a.o
   ? dir/c.o
 
   $ echo "relglob:*" > .hgignore
   $ hg status
   A dir/b.o
 
   $ cd dir
   $ hg status .
   A b.o
 
   $ hg debugignore
   <includematcher includes='(?:|.*/)[^/]*(?:/|$)'>
 
   $ hg debugignore b.o
   b.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 1: '*') (glob)
 
   $ cd ..
 
 Check patterns that match only the directory
 
 "(fsmonitor !)" below assumes that fsmonitor is enabled with
 "walk_on_invalidate = false" (default), which doesn't involve
 re-walking whole repository at detection of .hgignore change.
 
   $ echo "^dir\$" > .hgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? a.o
   ? dir/c.o (fsmonitor !)
   ? syntax
 
 Check recursive glob pattern matches no directories (dir/**/c.o matches dir/c.o)
 
   $ echo "syntax: glob" > .hgignore
   $ echo "dir/**/c.o" >> .hgignore
   $ touch dir/c.o
   $ mkdir dir/subdir
   $ touch dir/subdir/c.o
   $ hg status
   A dir/b.o
   ? .hgignore
   ? a.c
   ? a.o
   ? syntax
   $ hg debugignore a.c
   a.c is not ignored
   $ hg debugignore dir/c.o
   dir/c.o is ignored
   (ignore rule in $TESTTMP/ignorerepo/.hgignore, line 2: 'dir/**/c.o') (glob)
 
 Check rooted globs
 
   $ hg purge --all --config extensions.purge=
   $ echo "syntax: rootglob" > .hgignore
   $ echo "a/*.ext" >> .hgignore
   $ for p in a b/a aa; do mkdir -p $p; touch $p/b.ext; done
   $ hg status -A 'set:**.ext'
   ? aa/b.ext
   ? b/a/b.ext
   I a/b.ext
 
 Check using 'include:' in ignore file
 
   $ hg purge --all --config extensions.purge=
   $ touch foo.included
 
   $ echo ".*.included" > otherignore
   $ hg status -I "include:otherignore"
   ? foo.included
 
   $ echo "include:otherignore" >> .hgignore
   $ hg status
   A dir/b.o
   ? .hgignore
   ? otherignore
 
 Check recursive uses of 'include:'
 
   $ echo "include:nested/ignore" >> otherignore
   $ mkdir nested nested/more
   $ echo "glob:*ignore" > nested/ignore
   $ echo "rootglob:a" >> nested/ignore
   $ touch a nested/a nested/more/a
   $ hg status
   A dir/b.o
   ? nested/a
   ? nested/more/a
   $ rm a nested/a nested/more/a
 
   $ cp otherignore goodignore
   $ echo "include:badignore" >> otherignore
   $ hg status
   skipping unreadable pattern file 'badignore': $ENOENT$
   A dir/b.o
 
   $ mv goodignore otherignore
 
 Check using 'include:' while in a non-root directory
 
   $ cd ..
   $ hg -R ignorerepo status
   A dir/b.o
   $ cd ignorerepo
 
 Check including subincludes
 
   $ hg revert -q --all
   $ hg purge --all --config extensions.purge=
   $ echo ".hgignore" > .hgignore
   $ mkdir dir1 dir2
   $ touch dir1/file1 dir1/file2 dir2/file1 dir2/file2
   $ echo "subinclude:dir2/.hgignore" >> .hgignore
   $ echo "glob:file*2" > dir2/.hgignore
   $ hg status
   ? dir1/file1
   ? dir1/file2
   ? dir2/file1
 
 Check including subincludes with other patterns
 
   $ echo "subinclude:dir1/.hgignore" >> .hgignore
 
   $ mkdir dir1/subdir
   $ touch dir1/subdir/file1
   $ echo "rootglob:f?le1" > dir1/.hgignore
   $ hg status
   ? dir1/file2
   ? dir1/subdir/file1
   ? dir2/file1
   $ rm dir1/subdir/file1
 
   $ echo "regexp:f.le1" > dir1/.hgignore
   $ hg status
   ? dir1/file2
   ? dir2/file1
 
 Check multiple levels of sub-ignores
 
   $ touch dir1/subdir/subfile1 dir1/subdir/subfile3 dir1/subdir/subfile4
   $ echo "subinclude:subdir/.hgignore" >> dir1/.hgignore
   $ echo "glob:subfil*3" >> dir1/subdir/.hgignore
 
   $ hg status
   ? dir1/file2
   ? dir1/subdir/subfile4
   ? dir2/file1
 
 Check include subignore at the same level
 
   $ mv dir1/subdir/.hgignore dir1/.hgignoretwo
   $ echo "regexp:f.le1" > dir1/.hgignore
   $ echo "subinclude:.hgignoretwo" >> dir1/.hgignore
   $ echo "glob:file*2" > dir1/.hgignoretwo
 
   $ hg status | grep file2
   [1]
   $ hg debugignore dir1/file2
   dir1/file2 is ignored
   (ignore rule in dir2/.hgignore, line 1: 'file*2')
 
 #if windows
 
 Windows paths are accepted on input
 
   $ rm dir1/.hgignore
   $ echo "dir1/file*" >> .hgignore
   $ hg debugignore "dir1\file2"
-  dir1\file2 is ignored
+  dir1/file2 is ignored
   (ignore rule in $TESTTMP\ignorerepo\.hgignore, line 4: 'dir1/file*')
   $ hg up -qC .
 
 #endif