[PATCH] Clean up destination directory if a clone fails.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[PATCH] Clean up destination directory if a clone fails.

From: Bryan O'Sullivan <[e-mail]>

On Mon, 2005-06-27 at 16:27 +0800, Soh Tk-r28629 wrote:

> Hg clone left the dest directory if the source isn't valid.
> I think it should either validate the source before mkdir, or do a
> rmdir to clean it up.

Good suggestion, thanks.  As validating the source in advance isn't
really practical, I opted for the latter.

manifest hash: 1508afddd2402142f9d8b2387652d4cb28ccc1f5
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCwRGPywK+sNU5EO8RApBOAJ9Fj22MP3pYJhxWsj8BYbcgWzIOKwCff9yC
lX87RrDKicM1W61lBpQl20w=
=efck
-----END PGP SIGNATURE-----

mercurial/commands.py

@@ -273,10 +273,16 b' def clone(ui, source, dest = None, **opt'
 
     if source in paths: source = paths[source]
 
+    created = False
+
     if dest is None:
         dest = os.getcwd()
     elif not os.path.exists(dest):
-        os.makedirs(dest)
+        os.mkdir(dest)
+        created = True
+
+    try:
+        dest = os.path.realpath(dest)
 
     link = 0
     if not source.startswith("http://"):
@@ -308,6 +314,11 b' def clone(ui, source, dest = None, **opt'
 
     if not opts['no-update']:
         update(ui, repo)
+    except:
+        if created:
+            import shutil
+            shutil.rmtree(dest, True)
+        raise
     
 def commit(ui, repo, *files, **opts):
     """commit the specified files or all outstanding changes"""