Backed out changeset fce065538bcf: it caused a 5x performance regression on OS X

mercurial/util.py

@@ -38,12 +38,14 b' def _fastsha1(s):'
 
 import subprocess
 closefds = os.name == 'posix'
-def popen2(cmd):
-    p = subprocess.Popen(cmd, shell=True, close_fds=closefds,
+def popen2(cmd, bufsize=-1):
+    p = subprocess.Popen(cmd, shell=True, bufsize=bufsize,
+                         close_fds=closefds,
                          stdin=subprocess.PIPE, stdout=subprocess.PIPE)
     return p.stdin, p.stdout
-def popen3(cmd):
-    p = subprocess.Popen(cmd, shell=True, close_fds=closefds,
+def popen3(cmd, bufsize=-1):
+    p = subprocess.Popen(cmd, shell=True, bufsize=bufsize,
+                         close_fds=closefds,
                          stdin=subprocess.PIPE, stdout=subprocess.PIPE,
                          stderr=subprocess.PIPE)
     return p.stdin, p.stdout, p.stderr