Always remove appendopener tmp files (fixes issue235).

test-hup triggered this bug by killing "hg serve --stdio".

mercurial/appendfile.py

@@ -134,10 +134,16 b' class appendopener(object):'
             s = fp.read()
             fp.close()
             os.unlink(tmpname)
+            del self.tmpnames[name]
             fp = self.realopener(name, 'a')
             fp.write(s)
             fp.close()
 
+    def cleanup(self):
+        '''delete temp files (this discards unwritten data!)'''
+        for tmpname in self.tmpnames.values():
+            os.unlink(tmpname)
+
 # files for changelog and manifest are in different appendopeners, so
 # not mixed up together.
 

mercurial/localrepo.py

@@ -1477,6 +1477,8 b' class localrepository(object):'
 
         # write changelog and manifest data to temp files so
         # concurrent readers will not see inconsistent view
+        cl = None
+        try:
         cl = appendfile.appendchangelog(self.opener, self.changelog.version)
 
         oldheads = len(cl.heads())
@@ -1491,7 +1493,10 b' class localrepository(object):'
             cnr = cor
         changesets = cnr - cor
 
-        mf = appendfile.appendmanifest(self.opener, self.manifest.version)
+            mf = None
+            try:
+                mf = appendfile.appendmanifest(self.opener,
+                                               self.manifest.version)
 
         # pull off the manifest group
         self.ui.status(_("adding manifests\n"))
@@ -1516,7 +1521,13 b' class localrepository(object):'
         # write order here is important so concurrent readers will see
         # consistent view of repo
         mf.writedata()
+            finally:
+                if mf:
+                    mf.cleanup()
         cl.writedata()
+        finally:
+            if cl:
+                cl.cleanup()
 
         # make changelog and manifest see real files again
         self.changelog = changelog.changelog(self.opener, self.changelog.version)