Show More
@@ -627,6 +627,8 b' def _children(repo, narrow, parentset):' | |||||
627 | for p in pr(r): |
|
627 | for p in pr(r): | |
628 | if p in parentset: |
|
628 | if p in parentset: | |
629 | cs.add(r) |
|
629 | cs.add(r) | |
|
630 | # XXX using a set to feed the baseset is wrong. Sets are not ordered. | |||
|
631 | # This does not break because of other fullreposet misbehavior. | |||
630 | return baseset(cs) |
|
632 | return baseset(cs) | |
631 |
|
633 | |||
632 | def children(repo, subset, x): |
|
634 | def children(repo, subset, x): | |
@@ -1105,6 +1107,8 b' def head(repo, subset, x):' | |||||
1105 | hs = set() |
|
1107 | hs = set() | |
1106 | for b, ls in repo.branchmap().iteritems(): |
|
1108 | for b, ls in repo.branchmap().iteritems(): | |
1107 | hs.update(repo[h].rev() for h in ls) |
|
1109 | hs.update(repo[h].rev() for h in ls) | |
|
1110 | # XXX using a set to feed the baseset is wrong. Sets are not ordered. | |||
|
1111 | # This does not break because of other fullreposet misbehavior. | |||
1108 | # XXX We should not be using '.filter' here, but combines subset with '&' |
|
1112 | # XXX We should not be using '.filter' here, but combines subset with '&' | |
1109 | # XXX We should combine with subset first: 'subset & baseset(...)'. This is |
|
1113 | # XXX We should combine with subset first: 'subset & baseset(...)'. This is | |
1110 | # necessary to ensure we preserve the order in subset. |
|
1114 | # necessary to ensure we preserve the order in subset. |
General Comments 0
You need to be logged in to leave comments.
Login now