##// END OF EJS Templates
commitctx: stop using weakref proxy for transaction...
commitctx: stop using weakref proxy for transaction This weakref proxy was introduced in 2007 by 30d4d8985dd8. If I understand it correctly, the logic at that time was relying on the transaction destructor, triggered at garbage collection time to rollback failed transaction. passing the object to sub function directly mean it would live in the function scope and be trapped in the traceback on exception, leading to the transaction rollback too late in some case. Modern transaction usage use explicit opening and closing of transaction and no longer rely on some internal reference counting details. So this weakref proxy is no longer necessary. Absolutely no test are affected when we drop it.
marmoute -
r45788:5d0998cc default
Show More
Name Size Modified Last Commit Author
/ mercurial / interfaces
__init__.py Loading ...
dirstate.py Loading ...
repository.py Loading ...
util.py Loading ...