upstream/mercurial-mirror Files · mercurial/interfaces/util.py

commitctx: stop using weakref proxy for transaction...

commitctx: stop using weakref proxy for transaction This weakref proxy was introduced in 2007 by 30d4d8985dd8. If I understand it correctly, the logic at that time was relying on the transaction destructor, triggered at garbage collection time to rollback failed transaction. passing the object to sub function directly mean it would live in the function scope and be trapped in the traceback on exception, leading to the transaction rollback too late in some case. Modern transaction usage use explicit opening and closing of transaction and no longer rely on some internal reference counting details. So this weakref proxy is no longer necessary. Absolutely no test are affected when we drop it.

Augie Fackler - - Load All Authors

File last commit:

r43347:687b865b default


                r45788:5d0998cc

default

Download file

             util.py
        
                    38 lines
            
             | 1.0 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / interfaces / util.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # util.py - Utilities for declaring interfaces.

      #

      # Copyright 2018 Gregory Szorc <gregory.szorc@gmail.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      # zope.interface imposes a run-time cost due to module import overhead and

      # bookkeeping for declaring interfaces. So, we use stubs for various

      # zope.interface primitives unless instructed otherwise.

      from __future__ import absolute_import

      from .. import encoding

      if encoding.environ.get(b'HGREALINTERFACES'):

          from ..thirdparty.zope import interface as zi

          Attribute = zi.Attribute

          Interface = zi.Interface

          implementer = zi.implementer

      else:

          class Attribute(object):

              def __init__(self, __name__, __doc__=b''):

                  pass

          class Interface(object):

              def __init__(

                  self, name, bases=(), attrs=None, __doc__=None, __module__=None

              ):

                  pass

          def implementer(*ifaces):

              def wrapper(cls):

                  return cls

              return wrapper

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# util.py - Utilities for declaring interfaces.
				#
				# Copyright 2018 Gregory Szorc <gregory.szorc@gmail.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				# zope.interface imposes a run-time cost due to module import overhead and
				# bookkeeping for declaring interfaces. So, we use stubs for various
				# zope.interface primitives unless instructed otherwise.

				from __future__ import absolute_import

				from .. import encoding

				if encoding.environ.get(b'HGREALINTERFACES'):
				from ..thirdparty.zope import interface as zi

				Attribute = zi.Attribute
				Interface = zi.Interface
				implementer = zi.implementer
				else:

				class Attribute(object):
				def __init__(self, __name__, __doc__=b''):
				pass

				class Interface(object):
				def __init__(
				self, name, bases=(), attrs=None, __doc__=None, __module__=None
				):
				pass

				def implementer(*ifaces):
				def wrapper(cls):
				return cls

				return wrapper