upstream/mercurial-mirror Files · tests/test-check-pylint.t

localrepo: handle ValueError during repository opening...

localrepo: handle ValueError during repository opening Python 3.8 can raise ValueError on attempt of an I/O operation against an illegal path. This was causing test-remotefilelog-gc.t to fail on Python 3.8. This commit teaches repository opening to handle ValueError and re-raise an Abort on failure. An arguably better solution would be to implement this logic in the vfs layer. But that seems like a bag of worms and I don't want to go down that rabbit hole. Until users report uncaught ValueError exceptions in the wild, I think it is fine to patch this at the only occurrence our test harness is finding it. Differential Revision: https://phab.mercurial-scm.org/D7944

Matt Harbison - - Load All Authors

File last commit:

r38206:6ae62d62 stable


                r45469:9e5b4dbe

default

Download file

             test-check-pylint.t
        
                    22 lines
            
             | 616 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-pylint.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require test-repo pylint hg10

      Run pylint for known rules we care about.

      -----------------------------------------

      There should be no recorded failures; fix the codebase before introducing a

      new check.

      Current checks:

      - W0102: no mutable default argument

        $ touch $TESTTMP/fakerc

        $ pylint --rcfile=$TESTTMP/fakerc --disable=all \

        >   --enable=W0102,C0321 \

        >   --reports=no \

        >   --ignore=thirdparty \

        >   mercurial hgdemandimport hgext hgext3rd | sed 's/\r$//'

        Using config file *fakerc (glob) (?)

         (?)

        ------------------------------------ (?)

        Your code has been rated at 10.00/10 (?)

         (?)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require test-repo pylint hg10

				Run pylint for known rules we care about.
				-----------------------------------------

				There should be no recorded failures; fix the codebase before introducing a
				new check.

				Current checks:
				- W0102: no mutable default argument

				$ touch $TESTTMP/fakerc
				$ pylint --rcfile=$TESTTMP/fakerc --disable=all \
				> --enable=W0102,C0321 \
				> --reports=no \
				> --ignore=thirdparty \
				> mercurial hgdemandimport hgext hgext3rd \| sed 's/\r$//'
				Using config file *fakerc (glob) (?)
				(?)
				------------------------------------ (?)
				Your code has been rated at 10.00/10 (?)
				(?)