##// END OF EJS Templates
typo, use keycodes object instead of magic numbers
Paul Ivanov -
Show More
@@ -238,7 +238,7 var IPython = (function (IPython) {
238 * @param {event} event -
238 * @param {event} event -
239 * @return {Boolean} `true` if CodeMirror should ignore the event, `false` Otherwise
239 * @return {Boolean} `true` if CodeMirror should ignore the event, `false` Otherwise
240 */
240 */
241 CodeCell.prototype.handle_keyevent = function (editor, event) {
241 Cell.prototype.handle_keyevent = function (editor, event) {
242
242
243 // console.log('CM', this.mode, event.which, event.type)
243 // console.log('CM', this.mode, event.which, event.type)
244
244
@@ -197,7 +197,7 var IPython = (function (IPython) {
197 if (event.keyCode === keycodes.enter && (event.shiftKey || event.ctrlKey || event.altKey)) {
197 if (event.keyCode === keycodes.enter && (event.shiftKey || event.ctrlKey || event.altKey)) {
198 // Always ignore shift-enter in CodeMirror as we handle it.
198 // Always ignore shift-enter in CodeMirror as we handle it.
199 return true;
199 return true;
200 } else if (event.which === 40 && event.type === 'keypress' && IPython.tooltip.time_before_tooltip >= 0) {
200 } else if (event.which === keycodes.down && event.type === 'keypress' && IPython.tooltip.time_before_tooltip >= 0) {
201 // triger on keypress (!) otherwise inconsistent event.which depending on plateform
201 // triger on keypress (!) otherwise inconsistent event.which depending on plateform
202 // browser and keyboard layout !
202 // browser and keyboard layout !
203 // Pressing '(' , request tooltip, don't forget to reappend it
203 // Pressing '(' , request tooltip, don't forget to reappend it
General Comments 0
You need to be logged in to leave comments. Login now