match: remove a mutable default argument

Mutable default arguments are know to the state of California to cause bugs.

mercurial/scmutil.py

@@ -753,7 +753,7 b' def expandpats(pats):'
         ret.append(kindpat)
     return ret
 
-def matchandpats(ctx, pats=[], opts={}, globbed=False, default='relpath',
+def matchandpats(ctx, pats=(), opts={}, globbed=False, default='relpath',
                  badfn=None):
     '''Return a matcher and the patterns that were used.
     The matcher will warn about bad matches, unless an alternate badfn callback